Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2700353002:
ChromeOS OOBE: Fix EULA Back button. (Closed)
|
Created:
3 years, 10 months ago by Alexander Alekseev Modified:
3 years, 10 months ago Reviewers:
achuithb CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChromeOS OOBE: Fix EULA Back button.
This Cl prevents duplicate "selected network connected" events
and fixes focus when returning to network selection dialog
after pressing "Back" button on EULA screen.
BUG=676774
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2700353002
Cr-Commit-Position: refs/heads/master@{#451979}
Committed: https://chromium.googlesource.com/chromium/src/+/b95cf24b16a79138e0f4c01375b3af62512dae2e
Patch Set 1 #
Total comments: 2
Patch Set 2 : Rebased. #Patch Set 3 : Updated comment. #
Messages
Total messages: 23 (14 generated)
Description was changed from ========== ChromeOS OOBE: Fix EULA Back button. This Cl prevents duplicate "selected network connected" events and fixes focus when returning to network selection dialog after pressing "Back" button on EULA screen. BUG=676774 ========== to ========== ChromeOS OOBE: Fix EULA Back button. This Cl prevents duplicate "selected network connected" events and fixes focus when returning to network selection dialog after pressing "Back" button on EULA screen. BUG=676774 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
alemate@chromium.org changed reviewers: + achuith@chromium.org
Please review.
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2700353002/diff/1/chrome/browser/resources/ch... File chrome/browser/resources/chromeos/login/oobe_dialog.js (right): https://codereview.chromium.org/2700353002/diff/1/chrome/browser/resources/ch... chrome/browser/resources/chromeos/login/oobe_dialog.js:32: TODO (alemate): fix this once event flow is updated. Is there a bug?
https://codereview.chromium.org/2700353002/diff/1/chrome/browser/resources/ch... File chrome/browser/resources/chromeos/login/oobe_dialog.js (right): https://codereview.chromium.org/2700353002/diff/1/chrome/browser/resources/ch... chrome/browser/resources/chromeos/login/oobe_dialog.js:32: TODO (alemate): fix this once event flow is updated. On 2017/02/20 01:08:16, achuithb wrote: > Is there a bug? It should probably be called "remove old OOBE code", but we don't have any issue like this yet.
The CQ bit was checked by alemate@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org Link to the patchset: https://codereview.chromium.org/2700353002/#ps40001 (title: "Updated comment.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by alemate@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by alemate@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487749387108110,
"parent_rev": "a15f587cbffe556277ca05a82a9b0eec6b9d1ad7", "commit_rev":
"b95cf24b16a79138e0f4c01375b3af62512dae2e"}
Message was sent while issue was closed.
Description was changed from ========== ChromeOS OOBE: Fix EULA Back button. This Cl prevents duplicate "selected network connected" events and fixes focus when returning to network selection dialog after pressing "Back" button on EULA screen. BUG=676774 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== ChromeOS OOBE: Fix EULA Back button. This Cl prevents duplicate "selected network connected" events and fixes focus when returning to network selection dialog after pressing "Back" button on EULA screen. BUG=676774 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2700353002 Cr-Commit-Position: refs/heads/master@{#451979} Committed: https://chromium.googlesource.com/chromium/src/+/b95cf24b16a79138e0f4c01375b3... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/b95cf24b16a79138e0f4c01375b3... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
