Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 2699503002: Change minimum DTMF event duration to be 40 milliseconds (Closed)
Patch Set: Change minimum DTMF event duration to be 40 milliseconds Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/pc/dtmfsender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvoiceengine.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine.cc b/webrtc/media/engine/webrtcvoiceengine.cc
index f96c8e741e04ad94075ad69add97fab351230e01..ff1c74653b2108033ffb78676e23c253e40142bf 100644
--- a/webrtc/media/engine/webrtcvoiceengine.cc
+++ b/webrtc/media/engine/webrtcvoiceengine.cc
@@ -102,8 +102,6 @@ const rtc::DiffServCodePoint kAudioDscpValue = rtc::DSCP_EF;
// Constants from voice_engine_defines.h.
const int kMinTelephoneEventCode = 0; // RFC4733 (Section 2.3.1)
const int kMaxTelephoneEventCode = 255;
-const int kMinTelephoneEventDuration = 100;
-const int kMaxTelephoneEventDuration = 60000; // Actual limit is 2^16
const int kMinPayloadType = 0;
const int kMaxPayloadType = 127;
@@ -2446,11 +2444,6 @@ bool WebRtcVoiceMediaChannel::InsertDtmf(uint32_t ssrc, int event,
LOG(LS_WARNING) << "DTMF event code " << event << " out of range.";
return false;
}
- if (duration < kMinTelephoneEventDuration ||
- duration > kMaxTelephoneEventDuration) {
- LOG(LS_WARNING) << "DTMF event duration " << duration << " out of range.";
- return false;
- }
RTC_DCHECK_NE(-1, dtmf_payload_freq_);
return it->second->SendTelephoneEvent(*dtmf_payload_type_, dtmf_payload_freq_,
event, duration);
« no previous file with comments | « no previous file | webrtc/pc/dtmfsender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698