Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: webrtc/pc/dtmfsender_unittest.cc

Issue 2699503002: Change minimum DTMF event duration to be 40 milliseconds (Closed)
Patch Set: Change minimum DTMF event duration to be 40 milliseconds Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« webrtc/pc/dtmfsender.cc ('K') | « webrtc/pc/dtmfsender.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 provider_->SetCanInsertDtmf(false); 327 provider_->SetCanInsertDtmf(false);
328 EXPECT_FALSE(dtmf_->InsertDtmf(tones, duration, inter_tone_gap)); 328 EXPECT_FALSE(dtmf_->InsertDtmf(tones, duration, inter_tone_gap));
329 } 329 }
330 330
331 TEST_F(DtmfSenderTest, InsertDtmfWithInvalidDurationOrGap) { 331 TEST_F(DtmfSenderTest, InsertDtmfWithInvalidDurationOrGap) {
332 std::string tones = "3,4"; 332 std::string tones = "3,4";
333 int duration = 100; 333 int duration = 100;
334 int inter_tone_gap = 50; 334 int inter_tone_gap = 50;
335 335
336 EXPECT_FALSE(dtmf_->InsertDtmf(tones, 6001, inter_tone_gap)); 336 EXPECT_FALSE(dtmf_->InsertDtmf(tones, 6001, inter_tone_gap));
337 EXPECT_FALSE(dtmf_->InsertDtmf(tones, 69, inter_tone_gap)); 337 EXPECT_FALSE(dtmf_->InsertDtmf(tones, 39, inter_tone_gap));
Taylor Brandstetter 2017/02/16 18:18:23 There should also be a test somewhere that "Insert
338 EXPECT_FALSE(dtmf_->InsertDtmf(tones, duration, 49)); 338 EXPECT_FALSE(dtmf_->InsertDtmf(tones, duration, 49));
339 339
340 EXPECT_TRUE(dtmf_->InsertDtmf(tones, duration, inter_tone_gap)); 340 EXPECT_TRUE(dtmf_->InsertDtmf(tones, duration, inter_tone_gap));
341 } 341 }
OLDNEW
« webrtc/pc/dtmfsender.cc ('K') | « webrtc/pc/dtmfsender.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698