Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 2699503002: Change minimum DTMF event duration to be 40 milliseconds (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 const int kIsacMaxBitrateBps = 56000; 95 const int kIsacMaxBitrateBps = 56000;
96 96
97 // Default audio dscp value. 97 // Default audio dscp value.
98 // See http://tools.ietf.org/html/rfc2474 for details. 98 // See http://tools.ietf.org/html/rfc2474 for details.
99 // See also http://tools.ietf.org/html/draft-jennings-rtcweb-qos-00 99 // See also http://tools.ietf.org/html/draft-jennings-rtcweb-qos-00
100 const rtc::DiffServCodePoint kAudioDscpValue = rtc::DSCP_EF; 100 const rtc::DiffServCodePoint kAudioDscpValue = rtc::DSCP_EF;
101 101
102 // Constants from voice_engine_defines.h. 102 // Constants from voice_engine_defines.h.
103 const int kMinTelephoneEventCode = 0; // RFC4733 (Section 2.3.1) 103 const int kMinTelephoneEventCode = 0; // RFC4733 (Section 2.3.1)
104 const int kMaxTelephoneEventCode = 255; 104 const int kMaxTelephoneEventCode = 255;
105 const int kMinTelephoneEventDuration = 100; 105 const int kMinTelephoneEventDuration = 40;
the sun 2017/02/14 21:57:35 Refer to https://w3c.github.io/webrtc-pc/#rtcdtmfs
106 const int kMaxTelephoneEventDuration = 60000; // Actual limit is 2^16 106 const int kMaxTelephoneEventDuration = 60000; // Actual limit is 2^16
107 107
108 const int kMinPayloadType = 0; 108 const int kMinPayloadType = 0;
109 const int kMaxPayloadType = 127; 109 const int kMaxPayloadType = 127;
110 110
111 class ProxySink : public webrtc::AudioSinkInterface { 111 class ProxySink : public webrtc::AudioSinkInterface {
112 public: 112 public:
113 ProxySink(AudioSinkInterface* sink) : sink_(sink) { RTC_DCHECK(sink); } 113 ProxySink(AudioSinkInterface* sink) : sink_(sink) { RTC_DCHECK(sink); }
114 114
115 void OnData(const Data& audio) override { sink_->OnData(audio); } 115 void OnData(const Data& audio) override { sink_->OnData(audio); }
(...skipping 2582 matching lines...) Expand 10 before | Expand all | Expand 10 after
2698 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread()); 2698 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
2699 const auto it = send_streams_.find(ssrc); 2699 const auto it = send_streams_.find(ssrc);
2700 if (it != send_streams_.end()) { 2700 if (it != send_streams_.end()) {
2701 return it->second->channel(); 2701 return it->second->channel();
2702 } 2702 }
2703 return -1; 2703 return -1;
2704 } 2704 }
2705 } // namespace cricket 2705 } // namespace cricket
2706 2706
2707 #endif // HAVE_WEBRTC_VOICE 2707 #endif // HAVE_WEBRTC_VOICE
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698