Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools-webrtc/ios/build_ios_libs.py

Issue 2698613004: Including extra_gn_args to log line. (Closed)
Patch Set: Refactoring (removing some duplication) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools-webrtc/ios/build_ios_libs.py
diff --git a/tools-webrtc/ios/build_ios_libs.py b/tools-webrtc/ios/build_ios_libs.py
index 37404831130381af74b620131899cc4f548f7298..25745e0351e58f9f4dfad52fb79f9a75a732e15f 100755
--- a/tools-webrtc/ios/build_ios_libs.py
+++ b/tools-webrtc/ios/build_ios_libs.py
@@ -115,10 +115,10 @@ def BuildWebRTC(output_dir, target_arch, flavor, build_type,
else:
raise ValueError('Build type "%s" is not supported.' % build_type)
- logging.info('Building WebRTC with args: %s', ' '.join(gn_args))
+ args_string = ' '.join(gn_args + extra_gn_args)
+ logging.info('Building WebRTC with args: %s', args_string)
- cmd = ['gn', 'gen', output_dir,
- '--args=' + ' '.join(gn_args + extra_gn_args)]
+ cmd = ['gn', 'gen', output_dir, '--args=' + args_string]
_RunCommand(cmd)
logging.info('Building target: %s', gn_target_name)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698