Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: components/favicon/core/BUILD.gn

Issue 2698473004: Split FaviconService and FaviconServiceImpl. (Closed)
Patch Set: Revert changes in ios/.../history_collection_view_controller_unittest.mm Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/content/content_favicon_driver_unittest.cc ('k') | components/favicon/core/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/BUILD.gn
diff --git a/components/favicon/core/BUILD.gn b/components/favicon/core/BUILD.gn
index 41aa876b07bf413bf2be15b556cb58f935a6efda..7d8c060d96ae2798e638b92757a12f48ec75de2d 100644
--- a/components/favicon/core/BUILD.gn
+++ b/components/favicon/core/BUILD.gn
@@ -16,6 +16,8 @@ static_library("core") {
"favicon_handler.h",
"favicon_service.cc",
"favicon_service.h",
+ "favicon_service_impl.cc",
+ "favicon_service_impl.h",
"favicon_url.cc",
"favicon_url.h",
"favicon_util.cc",
@@ -51,14 +53,19 @@ source_set("unit_tests") {
sources = [
"fallback_url_util_unittest.cc",
"favicon_handler_unittest.cc",
+ "favicon_service_impl_unittest.cc",
"large_icon_service_unittest.cc",
]
deps = [
":core",
"//base",
+ "//components/favicon/core/test:test_support",
"//components/favicon_base",
+ "//components/history/core/browser:browser",
+ "//components/history/core/test:test",
"//skia",
+ "//testing/gmock",
"//testing/gtest",
"//ui/base",
"//ui/gfx",
« no previous file with comments | « components/favicon/content/content_favicon_driver_unittest.cc ('k') | components/favicon/core/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698