Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: ios/chrome/browser/favicon/favicon_service_factory.cc

Issue 2698473004: Split FaviconService and FaviconServiceImpl. (Closed)
Patch Set: Revert changes in ios/.../history_collection_view_controller_unittest.mm Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/favicon/favicon_service_factory.h" 5 #include "ios/chrome/browser/favicon/favicon_service_factory.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/memory/singleton.h" 8 #include "base/memory/singleton.h"
9 #include "components/favicon/core/favicon_service.h" 9 #include "components/favicon/core/favicon_service_impl.h"
10 #include "components/keyed_service/core/service_access_type.h" 10 #include "components/keyed_service/core/service_access_type.h"
11 #include "components/keyed_service/ios/browser_state_dependency_manager.h" 11 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
12 #include "ios/chrome/browser/browser_state/chrome_browser_state.h" 12 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
13 #include "ios/chrome/browser/favicon/favicon_client_impl.h" 13 #include "ios/chrome/browser/favicon/favicon_client_impl.h"
14 #include "ios/chrome/browser/history/history_service_factory.h" 14 #include "ios/chrome/browser/history/history_service_factory.h"
15 15
16 namespace ios { 16 namespace ios {
17 17
18 // static 18 // static
19 favicon::FaviconService* FaviconServiceFactory::GetForBrowserState( 19 favicon::FaviconService* FaviconServiceFactory::GetForBrowserState(
(...skipping 25 matching lines...) Expand all
45 DependsOn(ios::HistoryServiceFactory::GetInstance()); 45 DependsOn(ios::HistoryServiceFactory::GetInstance());
46 } 46 }
47 47
48 FaviconServiceFactory::~FaviconServiceFactory() { 48 FaviconServiceFactory::~FaviconServiceFactory() {
49 } 49 }
50 50
51 std::unique_ptr<KeyedService> FaviconServiceFactory::BuildServiceInstanceFor( 51 std::unique_ptr<KeyedService> FaviconServiceFactory::BuildServiceInstanceFor(
52 web::BrowserState* context) const { 52 web::BrowserState* context) const {
53 ios::ChromeBrowserState* browser_state = 53 ios::ChromeBrowserState* browser_state =
54 ios::ChromeBrowserState::FromBrowserState(context); 54 ios::ChromeBrowserState::FromBrowserState(context);
55 return base::MakeUnique<favicon::FaviconService>( 55 return base::MakeUnique<favicon::FaviconServiceImpl>(
56 base::MakeUnique<FaviconClientImpl>(), 56 base::MakeUnique<FaviconClientImpl>(),
57 ios::HistoryServiceFactory::GetForBrowserState( 57 ios::HistoryServiceFactory::GetForBrowserState(
58 browser_state, ServiceAccessType::EXPLICIT_ACCESS)); 58 browser_state, ServiceAccessType::EXPLICIT_ACCESS));
59 } 59 }
60 60
61 bool FaviconServiceFactory::ServiceIsNULLWhileTesting() const { 61 bool FaviconServiceFactory::ServiceIsNULLWhileTesting() const {
62 return true; 62 return true;
63 } 63 }
64 64
65 } // namespace ios 65 } // namespace ios
OLDNEW
« no previous file with comments | « ios/chrome/app/spotlight/spotlight_manager_unittest.mm ('k') | ios/chrome/browser/ui/history/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698