Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: webrtc/audio/audio_receive_stream.cc

Issue 2697833002: Replace AudioReceiveStream::DeliverRtp with OnRtpPacket. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/audio/audio_receive_stream.cc
diff --git a/webrtc/audio/audio_receive_stream.cc b/webrtc/audio/audio_receive_stream.cc
index 05d6edfa4c1fccd33b953ec2e38c3c456eefcb83..c0893b9044f6239c60edab4c30f6c80e86f6e384 100644
--- a/webrtc/audio/audio_receive_stream.cc
+++ b/webrtc/audio/audio_receive_stream.cc
@@ -302,14 +302,12 @@ bool AudioReceiveStream::DeliverRtcp(const uint8_t* packet, size_t length) {
return channel_proxy_->ReceivedRTCPPacket(packet, length);
}
-bool AudioReceiveStream::DeliverRtp(const uint8_t* packet,
- size_t length,
- const PacketTime& packet_time) {
+void AudioReceiveStream::OnRtpPacket(const RtpPacketReceived& packet) {
the sun 2017/02/16 13:47:22 RtpPacketReceived is an odd typename for me. It so
nisse-webrtc 2017/02/16 14:35:05 Agreed. But this is not the time to change that.
// TODO(solenberg): Tests call this function on a network thread, libjingle
// calls on the worker thread. We should move towards always using a network
// thread. Then this check can be enabled.
// RTC_DCHECK(!thread_checker_.CalledOnValidThread());
- return channel_proxy_->ReceivedRTPPacket(packet, length, packet_time);
+ channel_proxy_->OnRtpPacket(packet);
the sun 2017/02/16 13:47:22 Thanks for removing the return value!
}
const webrtc::AudioReceiveStream::Config& AudioReceiveStream::config() const {

Powered by Google App Engine
This is Rietveld 408576698