Move iOS tests to XCTest from gtest.

webrtc/examples/BUILD.gn

 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../webrtc.gni")
 if (is_android) {
@@ skipping 415 matching lines @@
     ]
     public_configs = [ ":socketrocket_include_config" ]
 
     libs = [
       "CFNetwork.framework",
       "icucore",
     ]
   }
 
   if (rtc_include_tests) {
-    config("rtc_apprtcmobile_config") {
-      defines = [ "GTEST_RELATIVE_PATH" ]
-    }
-
-    rtc_test("apprtcmobile_tests") {
-      include_dirs = [ "objc/AppRTCMobile/ios" ]
-      deps = [
-        ":AppRTCMobile_lib",
-        ":apprtc_signaling",
-        "//testing/gtest",
-        "//third_party/ocmock",
-      ]
-
-      sources = [
-        "objc/AppRTCMobile/tests/ARDAppClientTest.mm",
-        "objc/AppRTCMobile/tests/ARDSettingsModelTests.mm",
-      ]
-
-      if (is_ios) {
-        info_plist = "objc/AppRTCMobile/ios/Info.plist"
+    if (is_ios) {

[daniela-webrtc, 2017/02/13 16:08:21]

This means that we'll no longer have Mac test target. Perhaps add a TODO with
bug tracking the target on that one?

[kthelgason, 2017/02/14 09:48:46]

Good call, thanks. Done.

+      rtc_source_set("apprtcmobile_test_sources") {
+        include_dirs = [
+          "objc/AppRTCMobile",
+          "objc/AppRTCMobile/ios",
+        ]
+        testonly = true
+        sources = [
+          "objc/AppRTCMobile/tests/ARDAppClient_xctest.mm",
+          "objc/AppRTCMobile/tests/ARDSDPUtils_xctest.mm",
+          "objc/AppRTCMobile/tests/ARDSettingsModel_xctest.mm",
+        ]
+        public_deps = [
+          ":AppRTCMobile_ios_frameworks",
+          ":AppRTCMobile_lib",
+          "//build/config/ios:xctest",
+          "//third_party/ocmock",
+        ]
+        configs += [ "//build/config/compiler:enable_arc" ]
       }
 
-      configs += [
-        ":rtc_apprtcmobile_config",
-        "//build/config/compiler:enable_arc",
-      ]
+      ios_xctest_test("apprtcmobile_tests") {

[kjellander_webrtc, 2017/02/14 09:04:10]

The rtc_test template in
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/webrtc.gni#232
gets the global configurations //webrtc:common_config and
//webrtc:common_inherited_config added to it, while this doesn't. I suspect that
could affect behavior depending on if code in this target actually uses any of
those defines etc, but going forward I think it's safest if we either:
* create our own rtc_ios_xctest_test template
* add those configurations to each instance of ios_xctest_test.

[kthelgason, 2017/02/14 09:48:46]

Done.

+        info_plist = "objc/AppRTCMobile/ios/Info.plist"
+        sources = [
+          "objc/AppRTCMobile/ios/main.m",
+        ]
+        deps = [
+          ":apprtcmobile_test_sources",
+        ]
+        ldflags = [ "-all_load" ]
+      }
     }
   }
 }
 
 if (is_linux || is_win) {
   config("peerconnection_client_warnings_config") {
     cflags = []
     if (is_win && is_clang) {
       cflags += [
         # Disable warnings failing when compiling with Clang on Windows.
@@ skipping 151 matching lines @@
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
 
     deps = [
       "../p2p:libstunprober",
       "../p2p:rtc_p2p",
       "../system_wrappers:field_trial_default",
     ]
   }
 }