Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: webrtc/modules/desktop_capture/shared_memory.h

Issue 2697453002: [DesktopCapturer] FallbackDesktopCapturerWrapper and its tests (Closed)
Patch Set: Resolve review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 public: 69 public:
70 SharedMemoryFactory() {} 70 SharedMemoryFactory() {}
71 virtual ~SharedMemoryFactory() {} 71 virtual ~SharedMemoryFactory() {}
72 72
73 virtual std::unique_ptr<SharedMemory> CreateSharedMemory(size_t size) = 0; 73 virtual std::unique_ptr<SharedMemory> CreateSharedMemory(size_t size) = 0;
74 74
75 private: 75 private:
76 RTC_DISALLOW_COPY_AND_ASSIGN(SharedMemoryFactory); 76 RTC_DISALLOW_COPY_AND_ASSIGN(SharedMemoryFactory);
77 }; 77 };
78 78
79 // Implementation to share a SharedMemoryFactory between DesktopCapturer
80 // instances.
81 class SharedMemoryFactoryWrapper : public SharedMemoryFactory {
Sergey Ulanov 2017/02/15 23:08:43 Suggest putting this class in fallback_desktop_cap
Hzj_jie 2017/02/16 01:57:07 Done.
82 public:
83 SharedMemoryFactoryWrapper(std::unique_ptr<SharedMemoryFactory> factory);
84 ~SharedMemoryFactoryWrapper() override;
85
86 // Creates a SharedMemoryFactory, which should not overlive current instance.
87 std::unique_ptr<SharedMemoryFactory> Wrap() const;
88
89 std::unique_ptr<SharedMemory> CreateSharedMemory(size_t size) override;
90
91 private:
92 SharedMemoryFactoryWrapper(SharedMemoryFactory* factory);
93
94 std::unique_ptr<SharedMemoryFactory> owned_factory_;
95 SharedMemoryFactory* shared_factory_ = nullptr;
96 };
97
79 } // namespace webrtc 98 } // namespace webrtc
80 99
81 #endif // WEBRTC_MODULES_DESKTOP_CAPTURE_SHARED_MEMORY_H_ 100 #endif // WEBRTC_MODULES_DESKTOP_CAPTURE_SHARED_MEMORY_H_
82 101
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698