Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: webrtc/base/string_to_number.h

Issue 2696003004: Added integer parsing functions in base/string_to_number.h (Closed)
Patch Set: Removed float support, moved template instances into .cc, made parsing stricter. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/string_to_number.h
diff --git a/webrtc/base/string_to_number.h b/webrtc/base/string_to_number.h
new file mode 100644
index 0000000000000000000000000000000000000000..c963f5bd5a14742c1af3d80f24a6257fe8eac58e
--- /dev/null
+++ b/webrtc/base/string_to_number.h
@@ -0,0 +1,63 @@
+/*
+ * Copyright 2017 The WebRTC Project Authors. All rights reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_BASE_STRING_TO_NUMBER_H_
+#define WEBRTC_BASE_STRING_TO_NUMBER_H_
+
+#include <string>
+#include <limits>
+
+#include "webrtc/base/optional.h"
+
+namespace rtc {
+
+// This file declares a family of functions to parse integers from strings.
+// The standard C library functions either fail to indicate errors (atoi, etc.)
+// or are a hassle to work with (strtol, sscanf, etc.). The standard C++ library
+// functions (std::stoi, etc.) indicate errors by throwing exceptions, which
+// are disabled in WebRTC.
+//
+// Integers are parsed using one of the following functions:
+// rtc::Optional<int-type> StringToNumber(const char* str, int base = 10);
+// rtc::Optional<int-type> StringToNumber(const std::string& str,
+// int base = 10);
+//
+// These functions parse a value from the beginning of a string into one of the
+// fundamental integer types, or returns an empty Optional if parsing
+// failed. Values outside of the range supported by the type will be
+// rejected. By setting base to 0, one of octal, decimal or hexadecimal will be
+// detected from the string's prefix (0, nothing or 0x, respectively).
+// If non-zero, base can be set to a value between 2 and 36 inclusively.
+//
+// If desired, this interface could be extended with support for floating-point
+// types.
+
+template <typename T>
+typename std::enable_if<std::is_integral<T>::value && std::is_signed<T>::value,
+ rtc::Optional<T>>::type
+StringToNumber(const char* str, int base = 10);
+
+template <typename T>
+typename std::enable_if<std::is_integral<T>::value &&
+ std::is_unsigned<T>::value,
+ rtc::Optional<T>>::type
+StringToNumber(const char* str, int base = 10);
+
+// The std::string overloads only exists if there is a matching const char*
+// version.
+template <typename T>
+auto StringToNumber(const std::string& str, int base = 10)
+ -> decltype(StringToNumber<T>(str.c_str(), base)) {
+ return StringToNumber<T>(str.c_str(), base);
+}
+
+} // namespace rtc
+
+#endif // WEBRTC_BASE_STRING_TO_NUMBER_H_

Powered by Google App Engine
This is Rietveld 408576698