Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: webrtc/base/string_to_number.cc

Issue 2696003004: Added integer parsing functions in base/string_to_number.h (Closed)
Patch Set: Separated implementation from templates. Made parsing stricter. Added a couple of specific tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/string_to_number.cc
diff --git a/webrtc/base/string_to_number.cc b/webrtc/base/string_to_number.cc
new file mode 100644
index 0000000000000000000000000000000000000000..edaaab3797367618743db55208ed26aa7c45bba5
--- /dev/null
+++ b/webrtc/base/string_to_number.cc
@@ -0,0 +1,48 @@
+/*
+ * Copyright 2017 The WebRTC Project Authors. All rights reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/base/string_to_number.h"
+
+namespace rtc {
+namespace string_to_number_internal {
+
+rtc::Optional<long long int> ParseSigned(const char* str, int base) {
+ RTC_DCHECK(str);
+ if (isdigit(str[0]) || str[0] == '-') {
+ char* end = nullptr;
+ errno = 0;
+ const long long int value = std::strtoll(str, &end, base);
+ if (end && *end == '\0' && end != str && errno == 0) {
+ return rtc::Optional<long long int>(value);
+ }
+ }
+ return rtc::Optional<long long int>();
+}
+
+rtc::Optional<unsigned long long int> ParseUnsigned(const char* str, int base) {
+ RTC_DCHECK(str);
+ if (isdigit(str[0]) || str[0] == '-') {
+ // Explicitly discard negative values. std::strtoull parsing causes unsigned
+ // wraparound. We cannot just reject values that start with -, though, since
+ // -0 is perfectly fine, as is -0000000000000000000000000000000.
+ const bool is_negative = str[0] == '-';
+ char* end = nullptr;
+ errno = 0;
+ const unsigned long long int value = std::strtoull(str, &end, base);
+ if (end && *end == '\0' && end != str && errno == 0 &&
+ (value == 0 || !is_negative)) {
+ return rtc::Optional<unsigned long long int>(value);
+ }
+ }
+ return rtc::Optional<unsigned long long int>();
+}
+
+} // namespace string_to_number_internal
+} // namespace rtc

Powered by Google App Engine
This is Rietveld 408576698