Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: webrtc/base/string_to_number.cc

Issue 2696003004: Added integer parsing functions in base/string_to_number.h (Closed)
Patch Set: Addressed comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/string_to_number.h ('k') | webrtc/base/string_to_number_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 /*
2 * Copyright 2017 The WebRTC Project Authors. All rights reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include <cstdlib>
12
13 #include "webrtc/base/string_to_number.h"
14
15 namespace rtc {
16 namespace string_to_number_internal {
17
18 rtc::Optional<signed_type> ParseSigned(const char* str, int base) {
19 RTC_DCHECK(str);
20 if (isdigit(str[0]) || str[0] == '-') {
21 char* end = nullptr;
22 errno = 0;
23 const signed_type value = std::strtoll(str, &end, base);
24 if (end && *end == '\0' && errno == 0) {
25 return rtc::Optional<signed_type>(value);
26 }
27 }
28 return rtc::Optional<signed_type>();
29 }
30
31 rtc::Optional<unsigned_type> ParseUnsigned(const char* str, int base) {
32 RTC_DCHECK(str);
33 if (isdigit(str[0]) || str[0] == '-') {
34 // Explicitly discard negative values. std::strtoull parsing causes unsigned
35 // wraparound. We cannot just reject values that start with -, though, since
36 // -0 is perfectly fine, as is -0000000000000000000000000000000.
37 const bool is_negative = str[0] == '-';
38 char* end = nullptr;
39 errno = 0;
40 const unsigned_type value = std::strtoull(str, &end, base);
41 if (end && *end == '\0' && errno == 0 && (value == 0 || !is_negative)) {
42 return rtc::Optional<unsigned_type>(value);
43 }
44 }
45 return rtc::Optional<unsigned_type>();
46 }
47
48 } // namespace string_to_number_internal
49 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/string_to_number.h ('k') | webrtc/base/string_to_number_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698