Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2121)

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe.h

Issue 2695923004: Add logging of delay-based bandwidth estimate. (Closed)
Patch Set: Only log BWE update if bitrate or state has changed. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/delay_based_bwe.h
diff --git a/webrtc/modules/congestion_controller/delay_based_bwe.h b/webrtc/modules/congestion_controller/delay_based_bwe.h
index d1a9676d59d43a2c4f1f8b8818e4362b4453e1bf..c02182bdd312e2c8ea835f0f8aeafe482fb3a532 100644
--- a/webrtc/modules/congestion_controller/delay_based_bwe.h
+++ b/webrtc/modules/congestion_controller/delay_based_bwe.h
@@ -31,6 +31,8 @@
namespace webrtc {
+class RtcEventLog;
+
class DelayBasedBwe {
public:
static const int64_t kStreamTimeOutMs = 2000;
@@ -44,7 +46,7 @@ class DelayBasedBwe {
uint32_t target_bitrate_bps;
};
- explicit DelayBasedBwe(Clock* clock);
+ DelayBasedBwe(RtcEventLog* event_log, Clock* clock);
virtual ~DelayBasedBwe() {}
Result IncomingPacketFeedbackVector(
@@ -91,6 +93,7 @@ class DelayBasedBwe {
const bool in_median_slope_experiment_;
rtc::ThreadChecker network_thread_;
+ RtcEventLog* const event_log_;
Clock* const clock_;
std::unique_ptr<InterArrival> inter_arrival_;
std::unique_ptr<OveruseEstimator> kalman_estimator_;
@@ -110,6 +113,8 @@ class DelayBasedBwe {
size_t median_slope_window_size_;
double median_slope_threshold_gain_;
int consecutive_delayed_feedbacks_;
+ uint32_t last_logged_bitrate_;
+ BandwidthUsage last_logged_state_;
RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(DelayBasedBwe);
};
« no previous file with comments | « webrtc/modules/congestion_controller/congestion_controller.cc ('k') | webrtc/modules/congestion_controller/delay_based_bwe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698