Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log_parser.h

Issue 2695923004: Add logging of delay-based bandwidth estimate. (Closed)
Patch Set: Only log BWE update if bitrate or state has changed. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log_parser.h
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log_parser.h b/webrtc/logging/rtc_event_log/rtc_event_log_parser.h
index 8472668d75229762ad6671883f1428fdfe910e8c..c81b8fb10eea597f95f3158124efb9ceb2982ee6 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log_parser.h
+++ b/webrtc/logging/rtc_event_log/rtc_event_log_parser.h
@@ -71,8 +71,8 @@ class ParsedRtcEventLog {
// Reads the header, direction, media type, header length and packet length
// from the RTP event at |index|, and stores the values in the corresponding
- // output parameters. The output parameters can be set to nullptr if those
- // values aren't needed.
+ // output parameters. Each output parameter can be set to nullptr if that
+ // value isn't needed.
// NB: The header must have space for at least IP_PACKET_SIZE bytes.
void GetRtpHeader(size_t index,
PacketDirection* incoming,
@@ -83,7 +83,7 @@ class ParsedRtcEventLog {
// Reads packet, direction, media type and packet length from the RTCP event
// at |index|, and stores the values in the corresponding output parameters.
- // The output parameters can be set to nullptr if those values aren't needed.
+ // Each output parameter can be set to nullptr if that value isn't needed.
// NB: The packet must have space for at least IP_PACKET_SIZE bytes.
void GetRtcpPacket(size_t index,
PacketDirection* incoming,
@@ -115,15 +115,24 @@ class ParsedRtcEventLog {
void GetAudioPlayout(size_t index, uint32_t* ssrc) const;
// Reads bitrate, fraction loss (as defined in RFC 1889) and total number of
- // expected packets from the BWE event at |index| and stores the values in
- // the corresponding output parameters. The output parameters can be set to
- // nullptr if those values aren't needed.
- // NB: The packet must have space for at least IP_PACKET_SIZE bytes.
+ // expected packets from the loss based BWE event at |index| and stores the
+ // values in
+ // the corresponding output parameters. Each output parameter can be set to
+ // nullptr if that
+ // value isn't needed.
void GetBwePacketLossEvent(size_t index,
int32_t* bitrate,
uint8_t* fraction_loss,
int32_t* total_packets) const;
+ // Reads bitrate and detector_state from the delay based BWE event at |index|
+ // and stores the values in the corresponding output parameters. Each output
+ // parameter can be set to nullptr if that
+ // value isn't needed.
+ void GetBwePacketDelayEvent(size_t index,
+ int32_t* bitrate,
+ BandwidthUsage* detector_state) const;
+
// Reads a audio network adaptation event to a (non-NULL)
// AudioNetworkAdaptor::EncoderRuntimeConfig struct. Only the fields that are
// stored in the protobuf will be written.
« no previous file with comments | « webrtc/logging/rtc_event_log/rtc_event_log.proto ('k') | webrtc/logging/rtc_event_log/rtc_event_log_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698