Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: webrtc/logging/rtc_event_log/rtc_event_log.proto

Issue 2695923004: Add logging of delay-based bandwidth estimate. (Closed)
Patch Set: Only log BWE update if bitrate or state has changed. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 syntax = "proto2"; 1 syntax = "proto2";
2 option optimize_for = LITE_RUNTIME; 2 option optimize_for = LITE_RUNTIME;
3 package webrtc.rtclog; 3 package webrtc.rtclog;
4 4
5 enum MediaType { 5 enum MediaType {
6 ANY = 0; 6 ANY = 0;
7 AUDIO = 1; 7 AUDIO = 1;
8 VIDEO = 2; 8 VIDEO = 2;
9 DATA = 3; 9 DATA = 3;
10 } 10 }
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 // optional - but required if type == RTCP_EVENT 49 // optional - but required if type == RTCP_EVENT
50 optional RtcpPacket rtcp_packet = 4; 50 optional RtcpPacket rtcp_packet = 4;
51 51
52 // optional - but required if type == AUDIO_PLAYOUT_EVENT 52 // optional - but required if type == AUDIO_PLAYOUT_EVENT
53 optional AudioPlayoutEvent audio_playout_event = 5; 53 optional AudioPlayoutEvent audio_playout_event = 5;
54 54
55 // optional - but required if type == BWE_PACKET_LOSS_EVENT 55 // optional - but required if type == BWE_PACKET_LOSS_EVENT
56 optional BwePacketLossEvent bwe_packet_loss_event = 6; 56 optional BwePacketLossEvent bwe_packet_loss_event = 6;
57 57
58 // optional - but required if type == BWE_PACKET_DELAY_EVENT
59 optional BwePacketDelayEvent bwe_packet_delay_event = 7;
60
58 // optional - but required if type == VIDEO_RECEIVER_CONFIG_EVENT 61 // optional - but required if type == VIDEO_RECEIVER_CONFIG_EVENT
59 optional VideoReceiveConfig video_receiver_config = 8; 62 optional VideoReceiveConfig video_receiver_config = 8;
60 63
61 // optional - but required if type == VIDEO_SENDER_CONFIG_EVENT 64 // optional - but required if type == VIDEO_SENDER_CONFIG_EVENT
62 optional VideoSendConfig video_sender_config = 9; 65 optional VideoSendConfig video_sender_config = 9;
63 66
64 // optional - but required if type == AUDIO_RECEIVER_CONFIG_EVENT 67 // optional - but required if type == AUDIO_RECEIVER_CONFIG_EVENT
65 optional AudioReceiveConfig audio_receiver_config = 10; 68 optional AudioReceiveConfig audio_receiver_config = 10;
66 69
67 // optional - but required if type == AUDIO_SENDER_CONFIG_EVENT 70 // optional - but required if type == AUDIO_SENDER_CONFIG_EVENT
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 // required - Fraction of lost packets since last receiver report 113 // required - Fraction of lost packets since last receiver report
111 // computed as floor( 256 * (#lost_packets / #total_packets) ). 114 // computed as floor( 256 * (#lost_packets / #total_packets) ).
112 // The possible values range from 0 to 255. 115 // The possible values range from 0 to 255.
113 optional uint32 fraction_loss = 2; 116 optional uint32 fraction_loss = 2;
114 117
115 // TODO(terelius): Is this really needed? Remove or make optional? 118 // TODO(terelius): Is this really needed? Remove or make optional?
116 // required - Total number of packets that the BWE update is based on. 119 // required - Total number of packets that the BWE update is based on.
117 optional int32 total_packets = 3; 120 optional int32 total_packets = 3;
118 } 121 }
119 122
123 message BwePacketDelayEvent {
124 enum DetectorState {
125 BWE_NORMAL = 0;
126 BWE_UNDERUSING = 1;
127 BWE_OVERUSING = 2;
128 }
129
130 // required - Bandwidth estimate (in bps) after the update.
131 optional int32 bitrate = 1;
132
133 // required - The state of the overuse detector.
134 optional DetectorState detector_state = 2;
135 }
136
120 // TODO(terelius): Video and audio streams could in principle share SSRC, 137 // TODO(terelius): Video and audio streams could in principle share SSRC,
121 // so identifying a stream based only on SSRC might not work. 138 // so identifying a stream based only on SSRC might not work.
122 // It might be better to use a combination of SSRC and media type 139 // It might be better to use a combination of SSRC and media type
123 // or SSRC and port number, but for now we will rely on SSRC only. 140 // or SSRC and port number, but for now we will rely on SSRC only.
124 message VideoReceiveConfig { 141 message VideoReceiveConfig {
125 // required - Synchronization source (stream identifier) to be received. 142 // required - Synchronization source (stream identifier) to be received.
126 optional uint32 remote_ssrc = 1; 143 optional uint32 remote_ssrc = 1;
127 // required - Sender SSRC used for sending RTCP (such as receiver reports). 144 // required - Sender SSRC used for sending RTCP (such as receiver reports).
128 optional uint32 local_ssrc = 2; 145 optional uint32 local_ssrc = 2;
129 146
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 optional float uplink_packet_loss_fraction = 3; 261 optional float uplink_packet_loss_fraction = 3;
245 262
246 // Whether forward error correction (FEC) is turned on or off. 263 // Whether forward error correction (FEC) is turned on or off.
247 optional bool enable_fec = 4; 264 optional bool enable_fec = 4;
248 265
249 // Whether discontinuous transmission (DTX) is turned on or off. 266 // Whether discontinuous transmission (DTX) is turned on or off.
250 optional bool enable_dtx = 5; 267 optional bool enable_dtx = 5;
251 268
252 // Number of audio channels that each encoded packet consists of. 269 // Number of audio channels that each encoded packet consists of.
253 optional uint32 num_channels = 6; 270 optional uint32 num_channels = 6;
254 } 271 }
OLDNEW
« no previous file with comments | « webrtc/logging/rtc_event_log/rtc_event_log.cc ('k') | webrtc/logging/rtc_event_log/rtc_event_log_parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698