Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: webrtc/logging/rtc_event_log/rtc_event_log.h

Issue 2695923004: Add logging of delay-based bandwidth estimate. (Closed)
Patch Set: Only log BWE update if bitrate or state has changed. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_ 11 #ifndef WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_
12 #define WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_ 12 #define WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_
13 13
14 #include <memory> 14 #include <memory>
15 #include <string> 15 #include <string>
16 16
17 #include "webrtc/base/platform_file.h" 17 #include "webrtc/base/platform_file.h"
18 #include "webrtc/call/audio_receive_stream.h" 18 #include "webrtc/call/audio_receive_stream.h"
19 #include "webrtc/call/audio_send_stream.h" 19 #include "webrtc/call/audio_send_stream.h"
20 #include "webrtc/modules/audio_coding/audio_network_adaptor/include/audio_networ k_adaptor.h" 20 #include "webrtc/modules/audio_coding/audio_network_adaptor/include/audio_networ k_adaptor.h"
21 #include "webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h"
21 #include "webrtc/video_receive_stream.h" 22 #include "webrtc/video_receive_stream.h"
22 #include "webrtc/video_send_stream.h" 23 #include "webrtc/video_send_stream.h"
23 24
24 namespace webrtc { 25 namespace webrtc {
25 26
26 // Forward declaration of storage class that is automatically generated from 27 // Forward declaration of storage class that is automatically generated from
27 // the protobuf file. 28 // the protobuf file.
28 namespace rtclog { 29 namespace rtclog {
29 class EventStream; 30 class EventStream;
30 } // namespace rtclog 31 } // namespace rtclog
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 size_t length) = 0; 109 size_t length) = 0;
109 110
110 // Logs an audio playout event. 111 // Logs an audio playout event.
111 virtual void LogAudioPlayout(uint32_t ssrc) = 0; 112 virtual void LogAudioPlayout(uint32_t ssrc) = 0;
112 113
113 // Logs a bitrate update from the bandwidth estimator based on packet loss. 114 // Logs a bitrate update from the bandwidth estimator based on packet loss.
114 virtual void LogBwePacketLossEvent(int32_t bitrate, 115 virtual void LogBwePacketLossEvent(int32_t bitrate,
115 uint8_t fraction_loss, 116 uint8_t fraction_loss,
116 int32_t total_packets) = 0; 117 int32_t total_packets) = 0;
117 118
119 // Logs a bitrate update from the bandwidth estimator based on delay changes.
120 virtual void LogBwePacketDelayEvent(int32_t bitrate,
121 BandwidthUsage detector_state) = 0;
122
118 // Logs audio encoder re-configuration driven by audio network adaptor. 123 // Logs audio encoder re-configuration driven by audio network adaptor.
119 virtual void LogAudioNetworkAdaptation( 124 virtual void LogAudioNetworkAdaptation(
120 const AudioNetworkAdaptor::EncoderRuntimeConfig& config) = 0; 125 const AudioNetworkAdaptor::EncoderRuntimeConfig& config) = 0;
121 126
122 // Reads an RtcEventLog file and returns true when reading was successful. 127 // Reads an RtcEventLog file and returns true when reading was successful.
123 // The result is stored in the given EventStream object. 128 // The result is stored in the given EventStream object.
124 // The order of the events in the EventStream is implementation defined. 129 // The order of the events in the EventStream is implementation defined.
125 // The current implementation writes a LOG_START event, then the old 130 // The current implementation writes a LOG_START event, then the old
126 // configurations, then the remaining events in timestamp order and finally 131 // configurations, then the remaining events in timestamp order and finally
127 // a LOG_END event. However, this might change without further notice. 132 // a LOG_END event. However, this might change without further notice.
(...skipping 25 matching lines...) Expand all
153 const uint8_t* header, 158 const uint8_t* header,
154 size_t packet_length) override {} 159 size_t packet_length) override {}
155 void LogRtcpPacket(PacketDirection direction, 160 void LogRtcpPacket(PacketDirection direction,
156 MediaType media_type, 161 MediaType media_type,
157 const uint8_t* packet, 162 const uint8_t* packet,
158 size_t length) override {} 163 size_t length) override {}
159 void LogAudioPlayout(uint32_t ssrc) override {} 164 void LogAudioPlayout(uint32_t ssrc) override {}
160 void LogBwePacketLossEvent(int32_t bitrate, 165 void LogBwePacketLossEvent(int32_t bitrate,
161 uint8_t fraction_loss, 166 uint8_t fraction_loss,
162 int32_t total_packets) override {} 167 int32_t total_packets) override {}
168 void LogBwePacketDelayEvent(int32_t bitrate,
169 BandwidthUsage detector_state) override {}
163 void LogAudioNetworkAdaptation( 170 void LogAudioNetworkAdaptation(
164 const AudioNetworkAdaptor::EncoderRuntimeConfig& config) override{}; 171 const AudioNetworkAdaptor::EncoderRuntimeConfig& config) override {}
165 }; 172 };
166 173
167 } // namespace webrtc 174 } // namespace webrtc
168 175
169 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_ 176 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_
OLDNEW
« no previous file with comments | « webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h ('k') | webrtc/logging/rtc_event_log/rtc_event_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698