Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7449)

Unified Diff: chrome/browser/spellchecker/spellcheck_service_browsertest.cc

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)
Patch Set: Remove dependency CL. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_service_browsertest.cc
diff --git a/chrome/browser/spellchecker/spellcheck_service_browsertest.cc b/chrome/browser/spellchecker/spellcheck_service_browsertest.cc
index 13deefa92cf75258fb5c63653c6f5f87228c98dc..e1733d12bec91e26be0cefff5e828f38adcfb112 100644
--- a/chrome/browser/spellchecker/spellcheck_service_browsertest.cc
+++ b/chrome/browser/spellchecker/spellcheck_service_browsertest.cc
@@ -14,6 +14,7 @@
#include "base/macros.h"
#include "base/path_service.h"
#include "base/run_loop.h"
+#include "base/strings/string_piece.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "base/synchronization/waitable_event.h"
@@ -129,9 +130,9 @@ class SpellcheckServiceBrowserTest : public InProcessBrowserTest {
std::string GetMultilingualDictionaries() {
const base::ListValue* list_value =
prefs_->GetList(spellcheck::prefs::kSpellCheckDictionaries);
- std::vector<std::string> dictionaries;
+ std::vector<base::StringPiece> dictionaries;
for (const auto& item_value : *list_value) {
- std::string dictionary;
+ base::StringPiece dictionary;
EXPECT_TRUE(item_value->GetAsString(&dictionary));
dictionaries.push_back(dictionary);
}
« no previous file with comments | « chrome/browser/net/safe_search_util.cc ('k') | chrome/browser/sync_file_system/drive_backend/metadata_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698