Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1689)

Unified Diff: android_webview/browser/command_line_helper.cc

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)
Patch Set: Remove dependency CL. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/feature_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/command_line_helper.cc
diff --git a/android_webview/browser/command_line_helper.cc b/android_webview/browser/command_line_helper.cc
index 29afae050050ed8f6fd0f7bd6cb6b2ab0f50a816..af1e50a412a6cfa87631a6c6b0e47d413355094a 100644
--- a/android_webview/browser/command_line_helper.cc
+++ b/android_webview/browser/command_line_helper.cc
@@ -9,6 +9,7 @@
#include "base/command_line.h"
#include "base/feature_list.h"
#include "base/stl_util.h"
+#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "content/public/common/content_switches.h"
@@ -34,9 +35,9 @@ void AddFeatureToList(base::CommandLine& command_line,
return;
}
- vector<string> features =
+ vector<base::StringPiece> features =
base::FeatureList::SplitFeatureListString(features_list);
- vector<string> other_features =
+ vector<base::StringPiece> other_features =
base::FeatureList::SplitFeatureListString(other_features_list);
if (!base::ContainsValue(features, feature_name) &&
« no previous file with comments | « no previous file | base/feature_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698