webrtc/modules/video_coding/DEPS - Issue 2695653002: Add support for creating HW codecs in VideoProcessor tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/modules/video_coding/DEPS

Issue 2695653002: Add support for creating HW codecs in VideoProcessor tests. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« webrtc/modules/video_coding/BUILD.gn ('K') | « webrtc/modules/video_coding/BUILD.gn ('k') | webrtc/modules/video_coding/codecs/test/android_test_initializer.h » ('j') | webrtc/modules/video_coding/codecs/test/android_test_initializer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+base",
	kjellander_webrtc 2017/02/13 14:31:08 Please don't add this so widely. Put it in somethi Please don't add this so widely. Put it in something stricter instead, like this: specific_include_rules = { "codecs/test/android_test_initializer\.cc": [ "+base/android", ], } brandtr 2017/02/13 16:23:02 Sounds good. I wasn't aware of "specific_include_r Show quoted text On 2017/02/13 14:31:08, kjellander_webrtc wrote: > Please don't add this so widely. Put it in something stricter instead, like > this: > > specific_include_rules = { > "codecs/test/android_test_initializer\.cc": [ > "+base/android", > ], > } Sounds good. I wasn't aware of "specific_include_rules".
2 "+third_party/ffmpeg",	3 "+third_party/ffmpeg",

3 "+third_party/openh264",	4 "+third_party/openh264",

4 "+vpx",	5 "+vpx",

5 "+webrtc/base",	6 "+webrtc/base",

6 "+webrtc/common_video",	7 "+webrtc/common_video",

7 "+webrtc/media/base",	8 "+webrtc/media/base",

	9 "+webrtc/media/engine",
	kjellander_webrtc 2017/02/13 14:31:08 I'm not sure what the plan is moving forward here I'm not sure what the plan is moving forward here (if video coding production code is going to depend on these in the future), but let's keep this strict as well for now: specific_include_rules = { ".test\.cc": [ "+webrtc/media/engine", "+webrtc/sdk", ], } brandtr* 2017/02/13 16:23:02 Done. Show quoted text On 2017/02/13 14:31:08, kjellander_webrtc wrote: > I'm not sure what the plan is moving forward here (if video coding production > code is going to depend on these in the future), but let's keep this strict as > well for now: > > specific_include_rules = { > ".*test\.cc": [ > "+webrtc/media/engine", > "+webrtc/sdk", > ], > } Done.
	10 "+webrtc/sdk",

8 "+webrtc/system_wrappers",	11 "+webrtc/system_wrappers",

9 "+webrtc/tools",	12 "+webrtc/tools",

10 ]	13 ]

OLD	NEW