Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc

Issue 2695243005: Injectable audio encoders: BuiltinAudioEncoderFactory (Closed)
Patch Set: Fix build problems on Windows, Android and downstream. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc
diff --git a/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc b/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc
index 1f3936c8eeeeb92e67d3233c68f63a12cc298c4a..d5cf6163134fe98dd4b2e218553a15bd6e162317 100644
--- a/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc
+++ b/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc
@@ -10,8 +10,12 @@
#include "webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.h"
+#include <algorithm>
+
#include <limits>
#include "webrtc/base/checks.h"
+#include "webrtc/base/safe_conversions.h"
+#include "webrtc/base/string_to_number.h"
#include "webrtc/common_types.h"
#include "webrtc/modules/audio_coding/codecs/g722/g722_interface.h"
@@ -29,6 +33,22 @@ AudioEncoderG722::Config CreateConfig(const CodecInst& codec_inst) {
return config;
}
+AudioEncoderG722::Config CreateConfig(int payload_type,
+ const SdpAudioFormat& format) {
+ AudioEncoderG722::Config config;
+ config.payload_type = payload_type;
+ config.num_channels = format.num_channels;
+ auto ptime_iter = format.parameters.find("ptime");
+ if (ptime_iter != format.parameters.end()) {
+ auto ptime = rtc::StringToNumber<int>(ptime_iter->second);
+ if (ptime && *ptime > 0) {
+ const int whole_packets = *ptime / 10;
+ config.frame_size_ms = std::max(10, std::min(whole_packets * 10, 60));
+ }
+ }
+ return config;
+}
+
} // namespace
bool AudioEncoderG722::Config::IsOk() const {
@@ -58,8 +78,24 @@ AudioEncoderG722::AudioEncoderG722(const Config& config)
AudioEncoderG722::AudioEncoderG722(const CodecInst& codec_inst)
: AudioEncoderG722(CreateConfig(codec_inst)) {}
+AudioEncoderG722::AudioEncoderG722(int payload_type,
+ const SdpAudioFormat& format)
+ : AudioEncoderG722(CreateConfig(payload_type, format)) {}
+
AudioEncoderG722::~AudioEncoderG722() = default;
+rtc::Optional<AudioCodecInfo> AudioEncoderG722::QueryAudioEncoder(
+ const SdpAudioFormat& format) {
+ if (STR_CASE_CMP(format.name.c_str(), GetPayloadName()) == 0) {
+ Config config = CreateConfig(0, format);
+ if (format.clockrate_hz == 8000 && config.IsOk()) {
+ return rtc::Optional<AudioCodecInfo>(
+ {rtc::dchecked_cast<int>(kSampleRateHz), config.num_channels, 64000});
+ }
+ }
+ return rtc::Optional<AudioCodecInfo>();
+}
+
int AudioEncoderG722::SampleRateHz() const {
return kSampleRateHz;
}

Powered by Google App Engine
This is Rietveld 408576698