Clean up RTCVideoFrame

webrtc/sdk/objc/Framework/Classes/RTCVideoFrame+Private.h

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #import "WebRTC/RTCVideoFrame.h"
 
 #include "webrtc/api/video/video_frame_buffer.h"
-#include "webrtc/api/video/video_rotation.h"
 
 NS_ASSUME_NONNULL_BEGIN
 
 @interface RTCVideoFrame ()
 
-@property(nonatomic, readonly)
-    rtc::scoped_refptr<webrtc::VideoFrameBuffer> i420Buffer;
-
 - (instancetype)initWithVideoBuffer:
                     (rtc::scoped_refptr<webrtc::VideoFrameBuffer>)videoBuffer
-                           rotation:(webrtc::VideoRotation)rotation

[daniela-webrtc, 2017/02/17 16:26:34]

I think in general using Enums is better approach than int. Was there any
particular reason why you decided to remove this?

[magjed_webrtc, 2017/02/20 16:16:44]

It caused so many static casts in the implementation file. The reason we can't
use webrtc::VideoRotation in the public header is because it's C++ (because of
the namespace). It leads to this error:
../../webrtc/sdk/objc/Framework/Classes/RTCEAGLVideoView.m -o
obj/webrtc/sdk/objc/Framework/Classes/rtc_sdk_peerconnection_objc.RTCEAGLVideoView.o
In file included from
../../webrtc/sdk/objc/Framework/Classes/RTCEAGLVideoView.m:16:
In file included from
../../webrtc/sdk/objc/Framework/Headers/WebRTC//RTCVideoFrame.h:16:
../../webrtc/common_video/rotation.h:14:1: error: unknown type name 'namespace'
namespace webrtc {

I added a corresponding pure ObjC enum instead now.

[daniela-webrtc, 2017/02/21 08:30:18]

Acknowledged.

+                           rotation:(int)rotation
                         timeStampNs:(int64_t)timeStampNs
     NS_DESIGNATED_INITIALIZER;
 
 @end
 
 NS_ASSUME_NONNULL_END