Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: tools-webrtc/ios/tryserver.webrtc/ios_rel.json

Issue 2694423002: Revert of iOS: Use JSON for GN configuration instead of MB + remove symbols (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools-webrtc/ios/tryserver.webrtc/ios_dbg.json ('k') | tools-webrtc/mb/mb.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools-webrtc/ios/tryserver.webrtc/ios_rel.json
diff --git a/tools-webrtc/ios/tryserver.webrtc/ios_rel.json b/tools-webrtc/ios/tryserver.webrtc/ios_rel.json
index 154a3ed92abcc644a138a790bb5f97453d96ac66..a8601d7f926988d63db5e532606285e646d2134c 100644
--- a/tools-webrtc/ios/tryserver.webrtc/ios_rel.json
+++ b/tools-webrtc/ios/tryserver.webrtc/ios_rel.json
@@ -1,16 +1,14 @@
{
"comments": [
- "Builder for 32-bit devices."
+ "Builder for 32-bit devices.",
+ "gn_args in this file is only read by the buildbot recipe; ",
+ "webrtc/build/mb_config.pyl contains the actual build configuration.",
+ "TODO(kjellander): remove gn_args when the recipe is updated."
],
"xcode version": "8.0",
"gn_args": [
- "goma_dir=\"$(goma_dir)\"",
- "dcheck_always_on=true",
- "ios_enable_code_signing=false",
- "is_component_build=false",
"is_debug=false",
"target_cpu=\"arm\"",
- "target_os=\"ios\"",
"use_goma=true"
],
"use_analyze": false,
« no previous file with comments | « tools-webrtc/ios/tryserver.webrtc/ios_dbg.json ('k') | tools-webrtc/mb/mb.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698