tools-webrtc/ios/client.webrtc/iOS64_Sim_Debug_(iOS_10.0).json - Issue 2694423002: Revert of iOS: Use JSON for GN configuration instead of MB + remove symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools-webrtc/ios/client.webrtc/iOS64_Sim_Debug_(iOS_10.0).json

Issue 2694423002: Revert of iOS: Use JSON for GN configuration instead of MB + remove symbols (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools-webrtc/ios/client.webrtc/iOS64_Sim_Debug_(iOS_10.0).json

diff --git a/tools-webrtc/ios/client.webrtc/iOS64_Sim_Debug_(iOS_10.0).json b/tools-webrtc/ios/client.webrtc/iOS64_Sim_Debug_(iOS_10.0).json

index ad87ca184edec50bd262b17e87e7b9ac23ccc4a8..5c4fb8b6ba11148c5241915726ff0620f9cb4385 100644

--- a/tools-webrtc/ios/client.webrtc/iOS64_Sim_Debug_(iOS_10.0).json

+++ b/tools-webrtc/ios/client.webrtc/iOS64_Sim_Debug_(iOS_10.0).json

@@ -1,14 +1,14 @@

{

"comments": [

- "Tests for 64-bit iOS simulators."

+ "Tests for 64-bit iOS simulators.",

+ "gn_args in this file is only read by the buildbot recipe; ",

+ "webrtc/build/mb_config.pyl contains the actual build configuration.",

+ "TODO(kjellander): remove gn_args when the recipe is updated."

"xcode version": "8.0",

"gn_args": [

- "goma_dir=\"$(goma_dir)\"",

- "is_component_build=false",

"is_debug=true",

"target_cpu=\"x64\"",

- "target_os=\"ios\"",

"use_goma=true"

"additional_compile_targets": [ "all" ],