Low-bandwidth audio testing

webrtc/audio/BUILD.gn

Index: webrtc/audio/BUILD.gn
diff --git a/webrtc/audio/BUILD.gn b/webrtc/audio/BUILD.gn
index a6a22e652cce5cad47874baebe00acf9c1649cc2..224ceebe255d3d24f00997c9b7a89838e838c17a 100644
--- a/webrtc/audio/BUILD.gn
+++ b/webrtc/audio/BUILD.gn
@@ -78,6 +78,10 @@ if (rtc_include_tests) {
       "//testing/gmock",
       "//testing/gtest",
     ]
+    if (rtc_enable_protobuf) {
+      deps += [ ":low_bandwidth_audio_test" ]
+    }
+
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
@@ -87,15 +91,35 @@ if (rtc_include_tests) {
   if (rtc_enable_protobuf) {
     rtc_executable("low_bandwidth_audio_test") {
       testonly = true
+      configs += [ "..:rtc_unittests_config" ]

[kjellander_webrtc, 2017/03/17 07:11:41]

Why do you need this? To disable the warnings listen in
it?(https://cs.chromium.org/chromium/src/third_party/webrtc/BUILD.gn?rcl=c0a0f8d5f2d5b837b4c6ea447b0cdce86723e0d6&l=361)

If so, I suggest you fix them instead and remove this. If the warnings comes
from the deps you depend on it's another story, but I don't see where it would
come from (since that config is for making rtc_unittests compile).

[oprypin_webrtc, 2017/03/17 10:16:50]

OK, turns out it's not needed, thanks.

 
       sources = [
         "test/low_bandwidth_audio_test.cc",
+        "test/low_bandwidth_audio_test.h",
       ]
 
-      deps = []
-
+      deps = [
+        "../common_audio:common_audio",

[kjellander_webrtc, 2017/03/17 07:11:41]

Use "../common_audio" instead. It's the same (target named as the dir is
implicitly used if target is omitted)

[oprypin_webrtc, 2017/03/17 10:16:50]

Done.

+        "../system_wrappers:metrics_default",
+        "../system_wrappers:system_wrappers",

[kjellander_webrtc, 2017/03/17 07:11:41]

../system_wrappers is enough.

[oprypin_webrtc, 2017/03/17 10:16:50]

Done.

+        "../test:fake_audio_device",
+        "../test:run_test",
+        "../test:test_common",
+        "../test:test_main",
+      ]
       if (is_android) {
-        deps += [ "//testing/android/native_test:native_test_support" ]
+        deps += [ "//testing/android/native_test:native_test_native_code" ]
+      } else {
+        deps += [ "../modules/video_capture:video_capture_internal_impl" ]

[kjellander_webrtc, 2017/03/17 07:11:41]

What needs this? It seems we should try to move this dependency to that location
instead of here. I assume you got linking errors without it? Can you share the
output here?

[oprypin_webrtc, 2017/03/17 10:16:50]

Getting this error without this line:
../../webrtc/modules/video_capture/video_capture_factory.cc:22: error: undefined
reference to 'webrtc::videocapturemodule::VideoCaptureImpl::Create(char const*)'

I copied this from
https://cs.chromium.org/chromium/src/third_party/webrtc/video/BUILD.gn?l=96&r...

[kjellander_webrtc, 2017/03/17 10:37:18]

Hmm, I'm unable to see what pulls that in. That target depends on
//webrtc/test:video_test_common, which has capture stuff
(https://cs.chromium.org/chromium/src/third_party/webrtc/test/BUILD.gn?rcl=c0a...)
but your target doesn't pull in any capture code AFAICS.

We should figure this out to see if there's any refactoring needed.

+      }
+
+      data = [
+        "//resources/voice_engine/audio_tiny16.wav",
+      ]
+
+      if (!build_with_chromium && is_clang) {
+        # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163)
+        suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]

[kjellander_webrtc, 2017/03/17 07:11:41]

Is it possible to remove this or do you need it to compile the code you depend
on?

[oprypin_webrtc, 2017/03/17 10:16:50]

Getting this error without this line:
In file included from ../../webrtc/test/call_test.h:16:
In file included from ../../webrtc/call/call.h:19:
../../webrtc/call/audio_receive_stream.h:37:3: error: [chromium-style] Complex
class/struct needs an explicit out-of-line constructor.
...
and many more like this.

I copied this from
https://cs.chromium.org/chromium/src/third_party/webrtc/video/BUILD.gn?rcl=95...

[kjellander_webrtc, 2017/03/17 10:37:18]

I see. It's not your fault. Then we have to keep it.

       }
     }
   }