Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc

Issue 2693213005: Rename some variables and methods in RTC event log. (Closed)
Patch Set: Unset-upstream Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc b/webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc
index 97c82b3609dce27069f8ee56c0724797b8bd608a..ae264aaf4b652ed39e554a44d4a9c6eb50fc934c 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc
+++ b/webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc
@@ -283,7 +283,7 @@ void LogSessionAndReadBack(size_t rtp_count,
for (size_t i = 0; i < playout_count; i++) {
playout_ssrcs.push_back(prng.Rand<uint32_t>());
}
- // Create bwe_loss_count random bitrate updates for BwePacketLoss.
+ // Create bwe_loss_count random bitrate updates for LossBasedBwe.
for (size_t i = 0; i < bwe_loss_count; i++) {
bwe_loss_updates.push_back(
std::make_pair(prng.Rand<int32_t>(), prng.Rand<uint8_t>()));
@@ -333,7 +333,7 @@ void LogSessionAndReadBack(size_t rtp_count,
fake_clock.AdvanceTimeMicros(prng.Rand(1, 1000));
}
if (i * bwe_loss_count >= bwe_loss_index * rtp_count) {
- log_dumper->LogBwePacketLossEvent(
+ log_dumper->LogLossBasedBweUpdate(
bwe_loss_updates[bwe_loss_index - 1].first,
bwe_loss_updates[bwe_loss_index - 1].second, i);
bwe_loss_index++;
@@ -500,6 +500,94 @@ TEST(RtcEventLogTest, LogEventAndReadBack) {
remove(temp_filename.c_str());
}
+TEST(RtcEventLogTest, LogLossBasedBweUpdateAndReadBack) {
+ Random prng(1234);
+
+ // Generate a random packet loss event.
+ int32_t bitrate = prng.Rand(0, 10000000);
+ uint8_t fraction_lost = prng.Rand<uint8_t>();
+ int32_t total_packets = prng.Rand(1, 1000);
+
+ // Find the name of the current test, in order to use it as a temporary
+ // filename.
+ auto test_info = ::testing::UnitTest::GetInstance()->current_test_info();
+ const std::string temp_filename =
+ test::OutputPath() + test_info->test_case_name() + test_info->name();
+
+ // Start logging, add the packet loss event and then stop logging.
+ rtc::ScopedFakeClock fake_clock;
+ fake_clock.SetTimeMicros(prng.Rand<uint32_t>());
+ std::unique_ptr<RtcEventLog> log_dumper(RtcEventLog::Create());
+ log_dumper->StartLogging(temp_filename, 10000000);
+ fake_clock.AdvanceTimeMicros(prng.Rand(1, 1000));
+ log_dumper->LogLossBasedBweUpdate(bitrate, fraction_lost, total_packets);
+ fake_clock.AdvanceTimeMicros(prng.Rand(1, 1000));
+ log_dumper->StopLogging();
+
+ // Read the generated file from disk.
+ ParsedRtcEventLog parsed_log;
+ ASSERT_TRUE(parsed_log.ParseFile(temp_filename));
+
+ // Verify that what we read back from the event log is the same as
+ // what we wrote down.
+ EXPECT_EQ(3u, parsed_log.GetNumberOfEvents());
+ RtcEventLogTestHelper::VerifyLogStartEvent(parsed_log, 0);
+ RtcEventLogTestHelper::VerifyBweLossEvent(parsed_log, 1, bitrate,
+ fraction_lost, total_packets);
+ RtcEventLogTestHelper::VerifyLogEndEvent(parsed_log, 2);
+
+ // Clean up temporary file - can be pretty slow.
+ remove(temp_filename.c_str());
+}
+
+TEST(RtcEventLogTest, LogDelayBasedBweUpdateAndReadBack) {
+ Random prng(1234);
+
+ // Generate 3 random packet delay event.
+ int32_t bitrate1 = prng.Rand(0, 10000000);
+ int32_t bitrate2 = prng.Rand(0, 10000000);
+ int32_t bitrate3 = prng.Rand(0, 10000000);
+
+ // Find the name of the current test, in order to use it as a temporary
+ // filename.
+ auto test_info = ::testing::UnitTest::GetInstance()->current_test_info();
+ const std::string temp_filename =
+ test::OutputPath() + test_info->test_case_name() + test_info->name();
+
+ // Start logging, add the packet delay events and then stop logging.
+ rtc::ScopedFakeClock fake_clock;
+ fake_clock.SetTimeMicros(prng.Rand<uint32_t>());
+ std::unique_ptr<RtcEventLog> log_dumper(RtcEventLog::Create());
+ log_dumper->StartLogging(temp_filename, 10000000);
+ fake_clock.AdvanceTimeMicros(prng.Rand(1, 1000));
+ log_dumper->LogDelayBasedBweUpdate(bitrate1, kBwNormal);
+ fake_clock.AdvanceTimeMicros(prng.Rand(1, 1000));
+ log_dumper->LogDelayBasedBweUpdate(bitrate2, kBwOverusing);
+ fake_clock.AdvanceTimeMicros(prng.Rand(1, 1000));
+ log_dumper->LogDelayBasedBweUpdate(bitrate3, kBwUnderusing);
+ fake_clock.AdvanceTimeMicros(prng.Rand(1, 1000));
+ log_dumper->StopLogging();
+
+ // Read the generated file from disk.
+ ParsedRtcEventLog parsed_log;
+ ASSERT_TRUE(parsed_log.ParseFile(temp_filename));
+
+ // Verify that what we read back from the event log is the same as
+ // what we wrote down.
+ EXPECT_EQ(5u, parsed_log.GetNumberOfEvents());
+ RtcEventLogTestHelper::VerifyLogStartEvent(parsed_log, 0);
+ RtcEventLogTestHelper::VerifyBweDelayEvent(parsed_log, 1, bitrate1,
+ kBwNormal);
+ RtcEventLogTestHelper::VerifyBweDelayEvent(parsed_log, 2, bitrate2,
+ kBwOverusing);
+ RtcEventLogTestHelper::VerifyBweDelayEvent(parsed_log, 3, bitrate3,
+ kBwUnderusing);
+ RtcEventLogTestHelper::VerifyLogEndEvent(parsed_log, 4);
+
+ // Clean up temporary file - can be pretty slow.
+ remove(temp_filename.c_str());
+}
+
class ConfigReadWriteTest {
public:
ConfigReadWriteTest() : prng(987654321) {}
« no previous file with comments | « webrtc/logging/rtc_event_log/rtc_event_log_parser.cc ('k') | webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698