Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: webrtc/api/peerconnectioninterface.h

Issue 2692923002: Changing some PeerConnection-related comments. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/pc/peerconnectionfactory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 947 matching lines...) Expand 10 before | Expand all | Expand 10 after
958 958
959 // Creates a AudioSourceInterface. 959 // Creates a AudioSourceInterface.
960 // |options| decides audio processing settings. 960 // |options| decides audio processing settings.
961 virtual rtc::scoped_refptr<AudioSourceInterface> CreateAudioSource( 961 virtual rtc::scoped_refptr<AudioSourceInterface> CreateAudioSource(
962 const cricket::AudioOptions& options) = 0; 962 const cricket::AudioOptions& options) = 0;
963 // Deprecated - use version above. 963 // Deprecated - use version above.
964 // Can use CopyConstraintsIntoAudioOptions to bridge the gap. 964 // Can use CopyConstraintsIntoAudioOptions to bridge the gap.
965 virtual rtc::scoped_refptr<AudioSourceInterface> CreateAudioSource( 965 virtual rtc::scoped_refptr<AudioSourceInterface> CreateAudioSource(
966 const MediaConstraintsInterface* constraints) = 0; 966 const MediaConstraintsInterface* constraints) = 0;
967 967
968 // Creates a VideoTrackSourceInterface. The new source takes ownership of 968 // Creates a VideoTrackSourceInterface from |capturer|.
969 // |capturer|. 969 // TODO(deadbeef): We should aim to remove cricket::VideoCapturer from the
970 // API. It's mainly used as a wrapper around webrtc's provided
971 // platform-specific capturers, but these should be refactored to use
972 // VideoTrackSourceInterface directly.
970 // TODO(deadbeef): Make pure virtual once downstream mock PC factory classes 973 // TODO(deadbeef): Make pure virtual once downstream mock PC factory classes
971 // are updated. 974 // are updated.
972 virtual rtc::scoped_refptr<VideoTrackSourceInterface> CreateVideoSource( 975 virtual rtc::scoped_refptr<VideoTrackSourceInterface> CreateVideoSource(
973 std::unique_ptr<cricket::VideoCapturer> capturer) { 976 std::unique_ptr<cricket::VideoCapturer> capturer) {
974 return nullptr; 977 return nullptr;
975 } 978 }
976 979
977 // A video source creator that allows selection of resolution and frame rate. 980 // A video source creator that allows selection of resolution and frame rate.
978 // |constraints| decides video resolution and frame rate but can be NULL. 981 // |constraints| decides video resolution and frame rate but can be NULL.
979 // In the NULL case, use the version above. 982 // In the NULL case, use the version above.
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
1156 cricket::WebRtcVideoEncoderFactory* encoder_factory, 1159 cricket::WebRtcVideoEncoderFactory* encoder_factory,
1157 cricket::WebRtcVideoDecoderFactory* decoder_factory) { 1160 cricket::WebRtcVideoDecoderFactory* decoder_factory) {
1158 return CreatePeerConnectionFactory( 1161 return CreatePeerConnectionFactory(
1159 worker_and_network_thread, worker_and_network_thread, signaling_thread, 1162 worker_and_network_thread, worker_and_network_thread, signaling_thread,
1160 default_adm, encoder_factory, decoder_factory); 1163 default_adm, encoder_factory, decoder_factory);
1161 } 1164 }
1162 1165
1163 } // namespace webrtc 1166 } // namespace webrtc
1164 1167
1165 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_ 1168 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/pc/peerconnectionfactory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698