Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: webrtc/base/task_queue.h

Issue 2691973002: Add support for multimedia timers to TaskQueue on Windows. (Closed)
Patch Set: Add documentation, WAIT_OBJECT_0 and remove LOG(WARNING) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/base/task_queue_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/task_queue.h
diff --git a/webrtc/base/task_queue.h b/webrtc/base/task_queue.h
index eeabe05fabc886db22bddb0d085bf503d5cf275d..a6a70364ac4a19df27e28a2580efdeca6568f393 100644
--- a/webrtc/base/task_queue.h
+++ b/webrtc/base/task_queue.h
@@ -178,6 +178,11 @@ class LOCKABLE TaskQueue {
void PostTaskAndReply(std::unique_ptr<QueuedTask> task,
std::unique_ptr<QueuedTask> reply);
+ // Schedules a task to execute a specified number of milliseconds from when
+ // the call is made. The precision should be considered as "best effort"
+ // and in some cases, such as on Windows when all high precision timers have
+ // been used up, can be off by as much as 15 millseconds (although 8 would be
+ // more likely). This can be mitigated by limiting the use of delayed tasks.
void PostDelayedTask(std::unique_ptr<QueuedTask> task, uint32_t milliseconds);
template <class Closure>
@@ -185,6 +190,7 @@ class LOCKABLE TaskQueue {
PostTask(std::unique_ptr<QueuedTask>(new ClosureTask<Closure>(closure)));
}
+ // See documentation above for performance expectations.
template <class Closure>
void PostDelayedTask(const Closure& closure, uint32_t milliseconds) {
PostDelayedTask(
@@ -254,10 +260,12 @@ class LOCKABLE TaskQueue {
dispatch_queue_t queue_;
QueueContext* const context_;
#elif defined(WEBRTC_WIN)
+ class MultimediaTimer;
typedef std::unordered_map<UINT_PTR, std::unique_ptr<QueuedTask>>
DelayedTasks;
static bool ThreadMain(void* context);
- static bool ProcessQueuedMessages(DelayedTasks* delayed_tasks);
+ static bool ProcessQueuedMessages(DelayedTasks* delayed_tasks,
+ std::vector<MultimediaTimer>* timers);
class WorkerThread : public PlatformThread {
public:
« no previous file with comments | « no previous file | webrtc/base/task_queue_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698