Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: webrtc/sdk/android/src/jni/peerconnection_jni.cc

Issue 2690593002: Relanding: Add the url attribute to the IceCandidate (Java Wrapper) (Closed)
Patch Set: Add new ctor back and mark it private. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/sdk/android/api/org/webrtc/IceCandidate.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/android/src/jni/peerconnection_jni.cc
diff --git a/webrtc/sdk/android/src/jni/peerconnection_jni.cc b/webrtc/sdk/android/src/jni/peerconnection_jni.cc
index d3f23445d615e708049db976c0e6c8b9b50f3790..dfc109046317b721dad4f35b613500ffa327d796 100644
--- a/webrtc/sdk/android/src/jni/peerconnection_jni.cc
+++ b/webrtc/sdk/android/src/jni/peerconnection_jni.cc
@@ -245,12 +245,16 @@ class PCOJava : public PeerConnectionObserver {
std::string sdp;
RTC_CHECK(candidate->ToString(&sdp)) << "got so far: " << sdp;
jclass candidate_class = FindClass(jni(), "org/webrtc/IceCandidate");
- jmethodID ctor = GetMethodID(jni(), candidate_class,
- "<init>", "(Ljava/lang/String;ILjava/lang/String;)V");
+ jmethodID ctor = GetMethodID(
+ jni(), candidate_class, "<init>",
+ "(Ljava/lang/String;ILjava/lang/String;Ljava/lang/String;)V");
jstring j_mid = JavaStringFromStdString(jni(), candidate->sdp_mid());
jstring j_sdp = JavaStringFromStdString(jni(), sdp);
- jobject j_candidate = jni()->NewObject(candidate_class, ctor, j_mid,
- candidate->sdp_mline_index(), j_sdp);
+ jstring j_url =
+ JavaStringFromStdString(jni(), candidate->candidate().url());
+ jobject j_candidate =
+ jni()->NewObject(candidate_class, ctor, j_mid,
+ candidate->sdp_mline_index(), j_sdp, j_url);
CHECK_EXCEPTION(jni()) << "error during NewObject";
jmethodID m = GetMethodID(jni(), *j_observer_class_,
"onIceCandidate", "(Lorg/webrtc/IceCandidate;)V");
« no previous file with comments | « webrtc/sdk/android/api/org/webrtc/IceCandidate.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698