Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceCandidate.h

Issue 2688943003: Add the URL attribute to cricket::Candiate. (Objc wrapper) (Closed)
Patch Set: Fix the format. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceCandidate.h
diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceCandidate.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceCandidate.h
index 9f472b8df057a432b389c1122a1368524c8200c1..e381045748792dd2c27eb2b7d27d8d4a55dab2ab 100644
--- a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceCandidate.h
+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceCandidate.h
@@ -32,6 +32,9 @@ RTC_EXPORT
/** The SDP string for this candidate. */
@property(nonatomic, readonly) NSString *sdp;
+/** The URL of the ICE server which this candidate is gathered from. */
+@property(nonatomic, readonly) NSString *serverUrl;
+
- (instancetype)init NS_UNAVAILABLE;
/**
@@ -40,6 +43,7 @@ RTC_EXPORT
- (instancetype)initWithSdp:(NSString *)sdp
sdpMLineIndex:(int)sdpMLineIndex
sdpMid:(nullable NSString *)sdpMid
+ serverUrl:(nullable NSString *)serverUrl
tkchin_webrtc 2017/02/13 23:29:50 This is a breaking API change. Can we keep the old
Taylor Brandstetter 2017/02/13 23:53:00 Also, since the URL is only something that comes o
Zhi Huang 2017/02/14 19:09:08 Oh, you are right. We should keep both constructor
Taylor Brandstetter 2017/02/14 21:40:03 Right. An application shouldn't ever need to const
NS_DESIGNATED_INITIALIZER;
@end

Powered by Google App Engine
This is Rietveld 408576698