Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceCandidate.h

Issue 2688943003: Add the URL attribute to cricket::Candiate. (Objc wrapper) (Closed)
Patch Set: Fix format and typo. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceCandidate.h
diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceCandidate.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceCandidate.h
index 9f472b8df057a432b389c1122a1368524c8200c1..7b80b9315ee11d791afbc81e24c9dd87386dfb31 100644
--- a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceCandidate.h
+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceCandidate.h
@@ -32,16 +32,26 @@ RTC_EXPORT
/** The SDP string for this candidate. */
@property(nonatomic, readonly) NSString *sdp;
+/** The URL of the ICE server which this candidate is gathered from. */
+@property(nonatomic, readonly) NSString *serverUrl;
tkchin_webrtc 2017/02/14 21:58:55 nonatomic, readonly, nullable unless there is alwa
Zhi Huang 2017/02/15 00:22:49 Done.
+
- (instancetype)init NS_UNAVAILABLE;
/**
- * Initialize an RTCIceCandidate from SDP.
+ * Deprecated. Use initWithSdpAndServerUrl instead.
tkchin_webrtc 2017/02/14 21:58:55 Revert changes in this file other than the additio
Zhi Huang 2017/02/15 00:22:49 Done.
*/
- (instancetype)initWithSdp:(NSString *)sdp
sdpMLineIndex:(int)sdpMLineIndex
- sdpMid:(nullable NSString *)sdpMid
- NS_DESIGNATED_INITIALIZER;
+ sdpMid:(nullable NSString *)sdpMid;
+/**
+* Initialize an RTCIceCandidate with SDP and the URL of the ICE server.
+*/
+- (instancetype)initWithSdpAndServerUrl:(NSString *)sdp
+ sdpMLineIndex:(int)sdpMLineIndex
+ sdpMid:(nullable NSString *)sdpMid
+ serverUrl:(nullable NSString *)serverUrl
+ NS_DESIGNATED_INITIALIZER;
@end
NS_ASSUME_NONNULL_END

Powered by Google App Engine
This is Rietveld 408576698