Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4224)

Unified Diff: webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java

Issue 2688843002: EglRenderer: Trigger framelisteners even on dropped frames by default. (Closed)
Patch Set: Changes according to magjed's comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java
diff --git a/webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java b/webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java
index 866ca59d68b335773ac21095b00d306f07891080..2a9d04f0460bbf5fdbeff16b157780ffdefc0186 100644
--- a/webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java
+++ b/webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java
@@ -111,21 +111,23 @@ public class SurfaceViewRenderer
/**
* Register a callback to be invoked when a new video frame has been received.
*
- * @param listener The callback to be invoked.
+ * @param listener The callback to be invoked. The callback will be invoked on the render thread.
+ * It should be lightweight and must not call removeFrameListener.
* @param scale The scale of the Bitmap passed to the callback, or 0 if no Bitmap is
* required.
* @param drawer Custom drawer to use for this frame listener.
*/
public void addFrameListener(
- EglRenderer.FrameListener listener, float scale, final RendererCommon.GlDrawer drawer) {
- eglRenderer.addFrameListener(listener, scale, drawer);
+ EglRenderer.FrameListener listener, float scale, RendererCommon.GlDrawer drawerParam) {
+ eglRenderer.addFrameListener(listener, scale, drawerParam);
}
/**
* Register a callback to be invoked when a new video frame has been received. This version uses
* the drawer of the EglRenderer that was passed in init.
*
- * @param listener The callback to be invoked.
+ * @param listener The callback to be invoked. The callback will be invoked on the render thread.
+ * It should be lightweight and must not call removeFrameListener.
* @param scale The scale of the Bitmap passed to the callback, or 0 if no Bitmap is
* required.
*/

Powered by Google App Engine
This is Rietveld 408576698