Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 2688493002: Fix flaky test introduced by r16478 and r16492 (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index e6056d6d98c53a2461afc1552d2812c41318216c..a029f58044d0d5e17067689236941d8dc62597da 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -1093,10 +1093,12 @@ void EndToEndTest::DecodesRetransmittedFrame(bool enable_rtx, bool enable_red) {
}
void OnFrame(const VideoFrame& frame) override {
- rtc::CritScope lock(&crit_);
- if (frame.timestamp() == retransmitted_timestamp_)
- observation_complete_.Set();
- rendered_timestamps_.push_back(frame.timestamp());
+ {
+ rtc::CritScope lock(&crit_);
+ if (frame.timestamp() == retransmitted_timestamp_)
+ observation_complete_.Set();
+ rendered_timestamps_.push_back(frame.timestamp());
+ }
orig_renderer_->OnFrame(frame);
}
@@ -1110,6 +1112,7 @@ void EndToEndTest::DecodesRetransmittedFrame(bool enable_rtx, bool enable_red) {
RTC_DCHECK(!orig_renderer_);
orig_renderer_ = (*receive_configs)[0].renderer;
RTC_DCHECK(orig_renderer_);
+ (*receive_configs)[0].disable_prerenderer_smoothing = true;
(*receive_configs)[0].renderer = this;
(*receive_configs)[0].rtp.nack.rtp_history_ms = kNackRtpHistoryMs;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698