Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools-webrtc/ios/client.webrtc/iOS32_Debug.json

Issue 2688103002: iOS: Use JSON for GN configuration instead of MB + remove symbols (Closed)
Patch Set: Enabling code signing on simulators Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools-webrtc/ios/client.webrtc/iOS32_Release.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools-webrtc/ios/client.webrtc/iOS32_Debug.json
diff --git a/tools-webrtc/ios/client.webrtc/iOS32_Debug.json b/tools-webrtc/ios/client.webrtc/iOS32_Debug.json
index 71ab117083211916eb30b9f6042815536c8d7eed..4f86af67a0df2abb5166675802d7c59553686703 100644
--- a/tools-webrtc/ios/client.webrtc/iOS32_Debug.json
+++ b/tools-webrtc/ios/client.webrtc/iOS32_Debug.json
@@ -1,14 +1,15 @@
{
"comments": [
- "Builder for 32-bit devices.",
- "gn_args in this file is only read by the buildbot recipe; ",
- "webrtc/build/mb_config.pyl contains the actual build configuration.",
- "TODO(kjellander): remove gn_args when the recipe is updated."
+ "Builder for 32-bit devices."
],
"xcode version": "8.0",
"gn_args": [
+ "goma_dir=\"$(goma_dir)\"",
+ "ios_enable_code_signing=false",
+ "is_component_build=false",
"is_debug=true",
"target_cpu=\"arm\"",
+ "target_os=\"ios\"",
"use_goma=true"
ehmaldonado_webrtc 2017/02/15 20:15:36 I think you might be missing "symbol_level=1" From
kjellander_webrtc 2017/02/15 20:28:27 Good catch. I don't think it matters. Chrome bots
],
"additional_compile_targets": [ "all" ],
« no previous file with comments | « no previous file | tools-webrtc/ios/client.webrtc/iOS32_Release.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698