iOS: Use JSON for GN configuration instead of MB + remove symbols

tools-webrtc/mb/mb_config.pyl

 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 # FOR DETAILS ON THIS FILE SEE THE MAIN COPY IN //tools/mb/mb_config.pyl.
 # This is configuration for standalone WebRTC bots. It is used to keep the bot
 # configurations source-side instead of in the buildbot scripts. That makes it
 # easy to try different configurations of GN args in tryjob patches.
 
 {
   # This is a map of buildbot master names -> buildbot builder names ->
   # config names (where each config name is a key in the 'configs' dict,
   # above). mb uses this dict to look up which config to use for a given bot.
   # The builders should be sorted by the order they appear in the /builders
   # page on the buildbots, *not* alphabetically.
   'masters': {
     'client.webrtc': {
       # iOS
-      'iOS32 Debug': 'ios_debug_static_bot_arm_device',
-      'iOS32 Release': 'ios_release_bot_arm_device',
-      'iOS64 Debug': 'ios_debug_static_bot_arm64_device',
-      'iOS64 Release': 'ios_release_bot_arm64_device',
-      'iOS32 Sim Debug (iOS 9.0)': 'ios_debug_static_bot_x86',
-      'iOS64 Sim Debug (iOS 9.0)': 'ios_debug_static_bot_x64',
-      'iOS64 Sim Debug (iOS 10.0)': 'ios_debug_static_bot_x64',
+      'iOS32 Debug': 'ios',
+      'iOS32 Release': 'ios',
+      'iOS64 Debug': 'ios',
+      'iOS64 Release': 'ios',
+      'iOS32 Sim Debug (iOS 9.0)': 'ios',
+      'iOS64 Sim Debug (iOS 9.0)': 'ios',
+      'iOS64 Sim Debug (iOS 10.0)': 'ios',
 
       # Mac
       'Mac64 Debug': 'debug_bot_x64',
       'Mac64 Release': 'release_bot_x64',
       'Mac Asan': 'mac_asan_clang_release_bot_x64',
       'Mac64 Release [large tests]': 'release_bot_x64',
 
       # Linux
       'Linux32 Debug': 'debug_bot_x86',
       'Linux32 Release': 'release_bot_x86',
@@ skipping 58 matching lines @@
       'Android (swarming)': 'android_release_bot_arm',
       'Android ASan (swarming)': 'android_asan_shared_release_bot_arm',
       # Windows
       'Win (swarming)': 'release_bot_x86',
       'Win32 ASan (swarming)': 'win_asan_clang_release_bot_x86',
       'Win64 Debug (Win8)': 'debug_bot_x64',
       'Win64 Debug (Win10)': 'debug_bot_x64',
     },
     'tryserver.webrtc': {
       # iOS
-      'ios_dbg': 'ios_debug_static_bot_arm_device',
-      'ios_rel': 'ios_release_bot_arm_device',
-      'ios_arm64_dbg': 'ios_debug_static_bot_arm64_device',
-      'ios_arm64_rel': 'ios_release_bot_arm64_device',
-      'ios32_sim_ios9_dbg': 'ios_debug_static_bot_x86',
-      'ios64_sim_ios9_dbg': 'ios_debug_static_bot_x64',
-      'ios64_sim_ios10_dbg': 'ios_debug_static_bot_x64',
+      'ios_dbg': 'ios',
+      'ios_rel': 'ios',
+      'ios_arm64_dbg': 'ios',
+      'ios_arm64_rel': 'ios',
+      'ios32_sim_ios9_dbg': 'ios',
+      'ios64_sim_ios9_dbg': 'ios',
+      'ios64_sim_ios10_dbg': 'ios',
 
       # Mac
       'mac_compile_dbg': 'debug_bot_x64',
       'mac_compile_rel': 'release_bot_x64',
       'mac_dbg': 'debug_bot_x64',
       'mac_rel': 'release_bot_x64',
       'mac_asan': 'mac_asan_clang_release_bot_x64',
       'mac_baremetal': 'release_bot_x64',
 
       # Linux
@@ skipping 46 matching lines @@
       'win_x64_win8': 'debug_bot_x64',
       'win_x64_win10': 'debug_bot_x64',
     }
   },
 
   # This is the list of configs that you can pass to mb; each config
   # represents a particular combination of gn args that we must support.
   # A given config *may* be platform-specific but is not necessarily so (i.e.,
   #  we might have mac, win, and linux bots all using the 'release_bot' config).
   'configs': {
-    # iOS
-    'ios_debug_static_bot_arm64_device': [
-      'ios', 'gn', 'debug_static_bot', 'arm64', 'device'
-    ],
-    'ios_release_bot_arm64_device': [
-      'ios', 'gn', 'release_bot', 'arm64', 'device'
-    ],
-    'ios_debug_static_bot_arm_device': [
-      'ios', 'gn', 'debug_static_bot', 'arm', 'device'
-    ],
-    'ios_release_bot_arm_device': [
-      'ios', 'gn', 'release_bot', 'arm', 'device'
-    ],
-    'ios_debug_static_bot_x86': [
-      'ios', 'gn', 'debug_static_bot', 'x86'
-    ],
-    'ios_debug_static_bot_x64': [
-      'ios', 'gn', 'debug_static_bot', 'x64'
-    ],
-
     # Linux, Mac and Windows
     'gcc_release_bot_x64': [
       'gn', 'gcc', 'release_bot', 'x64'
     ],
     'release_bot_arm': [
       'gn', 'openh264_release_bot', 'arm'
     ],
     'asan_lsan_clang_release_bot_x64': [
       'gn', 'asan', 'lsan', 'clang', 'openh264_release_bot', 'x64'
     ],
@@ skipping 27 matching lines @@
     'perf_release_bot_x64': [
       'gn', 'openh264', 'release', 'static', 'goma', 'x64'
     ],
     'libfuzzer_asan_release_bot_x64': [
       'libfuzzer', 'asan', 'optimize_for_fuzzing', 'openh264_release_bot', 'x64'
     ],
     'memcheck_release_bot_x64': [
       'memcheck', 'gn', 'openh264_release_bot', 'x64'
     ],
 
+    # iOS
+    # The 'ios' config is just used for auditing. iOS bots
+    # use the ios recipes and look up their GN arguments via files checked in
+    # under //tools-webrtc/ios/bots. It is an error to actually use one of these
+    # configs to generate the build files.
+    'ios': [ 'error'],
+
     # Windows
     'win_clang_debug_bot_x86': [
       'gn', 'clang', 'openh264_debug_bot', 'x86',
     ],
     'win_clang_release_bot_x86': [
       'gn', 'clang', 'openh264_release_bot', 'x86',
     ],
     'win_clang_debug_bot_x64': [
       'gn', 'clang', 'openh264_debug_bot', 'x64',
     ],
@@ skipping 89 matching lines @@
     },
 
     'debug_bot': {
       'mixins': ['debug', 'shared', 'goma'],
     },
 
     'debug_static_bot': {
       'mixins': ['debug', 'static', 'minimal_symbols', 'goma'],
     },
 
-    'device': {
-      'gn_args': 'ios_enable_code_signing=false',
-    },
-
     # This mixin is used to force configs that use it to fail. It
     # is used in two cases: when we have bots that we haven't looked
     # at yet and don't know whether they need MB or not, and for bots
     # that are test-only and should never run MB.
     'error': {
       'gn_args': 'error',
     },
 
     'full_symbols': {
       'gn_args': 'symbol_level=2',
     },
 
     'gcc': {
       'gn_args': 'is_clang=false use_sysroot=false',
     },
 
     'gn': {'type': 'gn'},
 
     'goma': {
       'gn_args': 'use_goma=true',
     },
 
-    'ios': {
-      'gn_args': 'target_os="ios"',
-    },
-
     'libfuzzer': {
       'gn_args': 'use_libfuzzer=true',
     },
 
     'lsan': {
       'gn_args': 'is_lsan=true',
     },
 
     'memcheck': {
       'gn_args': 'rtc_use_memcheck=true',
@@ skipping 66 matching lines @@
 
     'x64': {
       'gn_args': 'target_cpu="x64"',
     },
 
     'x86': {
       'gn_args': 'target_cpu="x86"',
     },
   },
 }