Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: webrtc/common_audio/smoothing_filter.h

Issue 2687433004: TWCC-PLR -based FecController doesn’t need smoothing (Closed)
Patch Set: Rebased. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/common_audio/smoothing_filter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 61
62 rtc::Optional<int64_t> init_end_time_ms_; 62 rtc::Optional<int64_t> init_end_time_ms_;
63 float last_sample_; 63 float last_sample_;
64 float alpha_; 64 float alpha_;
65 float state_; 65 float state_;
66 int64_t last_state_time_ms_; 66 int64_t last_state_time_ms_;
67 67
68 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(SmoothingFilterImpl); 68 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(SmoothingFilterImpl);
69 }; 69 };
70 70
71 class NullSmoothingFilter final : public SmoothingFilter {
minyue-webrtc 2017/03/22 09:40:55 can we move NullSmoothingFilter to fec controller
elad.alon_webrtc.org 2017/03/22 10:14:25 That's possible. On the other hand, what if somebo
72 public:
73 NullSmoothingFilter();
74 ~NullSmoothingFilter() override;
75 void AddSample(float sample) override;
76 rtc::Optional<float> GetAverage() override;
77 bool SetTimeConstantMs(int time_constant_ms) override;
78
79 private:
80 rtc::Optional<float> last_sample_;
81 };
82
71 } // namespace webrtc 83 } // namespace webrtc
72 84
73 #endif // WEBRTC_COMMON_AUDIO_SMOOTHING_FILTER_H_ 85 #endif // WEBRTC_COMMON_AUDIO_SMOOTHING_FILTER_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/common_audio/smoothing_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698