Pass isolate output dir to gtest-parallel-wrapper.py

tools-webrtc/mb/mb.py

Index: tools-webrtc/mb/mb.py
diff --git a/tools-webrtc/mb/mb.py b/tools-webrtc/mb/mb.py
index eb92f239f0c035586feae16caad3aad4ab4fb7f2..d186216ef0f21f1b53ff152af81b73ea19e79b61 100755
--- a/tools-webrtc/mb/mb.py
+++ b/tools-webrtc/mb/mb.py
@@ -1100,14 +1100,18 @@ class MetaBuildWrapper(object):
 
       gtest_parallel = (test_type != 'non_parallel_console_test_launcher' and
                         not memcheck)
-      gtest_parallel_wrapper = [
-          '../../third_party/gtest-parallel/gtest-parallel-wrapper.py'
-      ]
       if gtest_parallel:
         extra_files += [
             '../../third_party/gtest-parallel/gtest-parallel',
             '../../third_party/gtest-parallel/gtest-parallel-wrapper.py',
         ]
+        sep = '\\' if self.platform == 'win32' else '/'

[kjellander_webrtc, 2017/02/07 20:41:39]

Just use os.sep instead? https://docs.python.org/2/library/os.html#os.sep

[ehmaldonado_webrtc, 2017/02/10 17:50:27]

I guess the platform for which the isolate files are generated need not match
the one on which mb is executed.
For example, in the unittest we test the output for both linux and windows, so
we might be testing the case self.platform = 'win32' on linux.

[kjellander_webrtc, 2017/02/13 05:46:47]

Ah, you're right. I thought only to check this file, in which it's initialized
to sys.platform at line 53. But you're right, it's overridden in the test.
Maybe add a comment above to mention it's because of testability then.

+        output_dir = '${ISOLATED_OUTDIR}' + sep + 'test_logs'
+        gtest_parallel_wrapper = [
+            '../../third_party/gtest-parallel/gtest-parallel-wrapper.py',
+            '--output_dir=%s' % output_dir,
+            '--timeout=900', # 15 min.

[kjellander_webrtc, 2017/02/07 20:41:39]

I think we should make this more visible (but keeping it in mb.py will still
hide it quite well, I'm not sure what we should do about that).

Could you at least just extract it to a constant at the top of the file, like
TEST_TIMEOUT?

[ehmaldonado_webrtc, 2017/02/10 17:50:27]

Acknowledged.

+        ]
 
       asan = 'is_asan=true' in vals['gn_args']
       msan = 'is_msan=true' in vals['gn_args']