Rename flexfec AddAndProcessReceivedPacket --> OnRtpPacket.

webrtc/call/flexfec_receive_stream_impl.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 131 matching lines @@
   rtp_rtcp_->SetSSRC(config_.local_ssrc);
   process_thread_->RegisterModule(rtp_rtcp_.get());
 }
 
 FlexfecReceiveStreamImpl::~FlexfecReceiveStreamImpl() {
   LOG(LS_INFO) << "~FlexfecReceiveStreamImpl: " << config_.ToString();
   Stop();
   process_thread_->DeRegisterModule(rtp_rtcp_.get());
 }
 
-bool FlexfecReceiveStreamImpl::AddAndProcessReceivedPacket(
-    const RtpPacketReceived& packet) {
+void FlexfecReceiveStreamImpl::OnRtpPacket(const RtpPacketReceived& packet) {
   {
     rtc::CritScope cs(&crit_);
     if (!started_)
-      return false;
+      return;
   }
 
   if (!receiver_)
-    return false;
+    return;
 
   if (!receiver_->AddAndProcessReceivedPacket(packet))

[nisse-webrtc, 2017/02/10 13:46:21]

Should we rename and/or drop the return value for this method too?

Is it essential to exclude broken flexfec packets from the below statistics?

[brandtr, 2017/02/10 14:12:21]

Yes, might as well do both :)
Don't think so. What change do you want to make?

[nisse-webrtc, 2017/02/13 13:20:03]

If I delete return value and this if statement, as a consequence the below stats
call will be invoked also for invalid packets.

[brandtr, 2017/02/13 15:32:13]

I understand. I think it's fine to include those.

-    return false;
+    return;
 
   // Do not report media packets in the RTCP RRs generated by |rtp_rtcp_|.
   if (packet.Ssrc() == config_.remote_ssrc) {
     RTPHeader header;
     packet.GetHeader(&header);
     // FlexFEC packets are never retransmitted.
     const bool kNotRetransmitted = false;
     rtp_receive_statistics_->IncomingPacket(header, packet.size(),
                                             kNotRetransmitted);
   }
-
-  return true;
 }
 
 void FlexfecReceiveStreamImpl::Start() {
   rtc::CritScope cs(&crit_);
   started_ = true;
 }
 
 void FlexfecReceiveStreamImpl::Stop() {
   rtc::CritScope cs(&crit_);
   started_ = false;
 }
 
 // TODO(brandtr): Implement this member function when we have designed the
 // stats for FlexFEC.
 FlexfecReceiveStreamImpl::Stats FlexfecReceiveStreamImpl::GetStats() const {
   return FlexfecReceiveStream::Stats();
 }
 
 }  // namespace webrtc