Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: webrtc/modules/audio_processing/echo_cancellation_impl_unittest.cc

Issue 2685783014: Replace NULL with nullptr in all C++ files. (Closed)
Patch Set: Fixing android. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include <memory> 11 #include <memory>
12 12
13 #include "webrtc/modules/audio_processing/aec/aec_core.h" 13 #include "webrtc/modules/audio_processing/aec/aec_core.h"
14 #include "webrtc/modules/audio_processing/include/audio_processing.h" 14 #include "webrtc/modules/audio_processing/include/audio_processing.h"
15 #include "webrtc/test/gtest.h" 15 #include "webrtc/test/gtest.h"
16 16
17 namespace webrtc { 17 namespace webrtc {
18 18
19 TEST(EchoCancellationInternalTest, ExtendedFilter) { 19 TEST(EchoCancellationInternalTest, ExtendedFilter) {
20 std::unique_ptr<AudioProcessing> ap(AudioProcessing::Create()); 20 std::unique_ptr<AudioProcessing> ap(AudioProcessing::Create());
21 EXPECT_TRUE(ap->echo_cancellation()->aec_core() == NULL); 21 EXPECT_TRUE(ap->echo_cancellation()->aec_core() == nullptr);
22 22
23 EXPECT_EQ(ap->kNoError, ap->echo_cancellation()->Enable(true)); 23 EXPECT_EQ(ap->kNoError, ap->echo_cancellation()->Enable(true));
24 EXPECT_TRUE(ap->echo_cancellation()->is_enabled()); 24 EXPECT_TRUE(ap->echo_cancellation()->is_enabled());
25 25
26 AecCore* aec_core = ap->echo_cancellation()->aec_core(); 26 AecCore* aec_core = ap->echo_cancellation()->aec_core();
27 ASSERT_TRUE(aec_core != NULL); 27 ASSERT_TRUE(aec_core != nullptr);
28 // Disabled by default. 28 // Disabled by default.
29 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core)); 29 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core));
30 30
31 Config config; 31 Config config;
32 config.Set<ExtendedFilter>(new ExtendedFilter(true)); 32 config.Set<ExtendedFilter>(new ExtendedFilter(true));
33 ap->SetExtraOptions(config); 33 ap->SetExtraOptions(config);
34 EXPECT_EQ(1, WebRtcAec_extended_filter_enabled(aec_core)); 34 EXPECT_EQ(1, WebRtcAec_extended_filter_enabled(aec_core));
35 35
36 // Retains setting after initialization. 36 // Retains setting after initialization.
37 EXPECT_EQ(ap->kNoError, ap->Initialize()); 37 EXPECT_EQ(ap->kNoError, ap->Initialize());
38 EXPECT_EQ(1, WebRtcAec_extended_filter_enabled(aec_core)); 38 EXPECT_EQ(1, WebRtcAec_extended_filter_enabled(aec_core));
39 39
40 config.Set<ExtendedFilter>(new ExtendedFilter(false)); 40 config.Set<ExtendedFilter>(new ExtendedFilter(false));
41 ap->SetExtraOptions(config); 41 ap->SetExtraOptions(config);
42 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core)); 42 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core));
43 43
44 // Retains setting after initialization. 44 // Retains setting after initialization.
45 EXPECT_EQ(ap->kNoError, ap->Initialize()); 45 EXPECT_EQ(ap->kNoError, ap->Initialize());
46 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core)); 46 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core));
47 } 47 }
48 48
49 TEST(EchoCancellationInternalTest, DelayAgnostic) { 49 TEST(EchoCancellationInternalTest, DelayAgnostic) {
50 std::unique_ptr<AudioProcessing> ap(AudioProcessing::Create()); 50 std::unique_ptr<AudioProcessing> ap(AudioProcessing::Create());
51 EXPECT_TRUE(ap->echo_cancellation()->aec_core() == NULL); 51 EXPECT_TRUE(ap->echo_cancellation()->aec_core() == nullptr);
52 52
53 EXPECT_EQ(ap->kNoError, ap->echo_cancellation()->Enable(true)); 53 EXPECT_EQ(ap->kNoError, ap->echo_cancellation()->Enable(true));
54 EXPECT_TRUE(ap->echo_cancellation()->is_enabled()); 54 EXPECT_TRUE(ap->echo_cancellation()->is_enabled());
55 55
56 AecCore* aec_core = ap->echo_cancellation()->aec_core(); 56 AecCore* aec_core = ap->echo_cancellation()->aec_core();
57 ASSERT_TRUE(aec_core != NULL); 57 ASSERT_TRUE(aec_core != nullptr);
58 // Enabled by default. 58 // Enabled by default.
59 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core)); 59 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core));
60 60
61 Config config; 61 Config config;
62 config.Set<DelayAgnostic>(new DelayAgnostic(true)); 62 config.Set<DelayAgnostic>(new DelayAgnostic(true));
63 ap->SetExtraOptions(config); 63 ap->SetExtraOptions(config);
64 EXPECT_EQ(1, WebRtcAec_delay_agnostic_enabled(aec_core)); 64 EXPECT_EQ(1, WebRtcAec_delay_agnostic_enabled(aec_core));
65 65
66 // Retains setting after initialization. 66 // Retains setting after initialization.
67 EXPECT_EQ(ap->kNoError, ap->Initialize()); 67 EXPECT_EQ(ap->kNoError, ap->Initialize());
68 EXPECT_EQ(1, WebRtcAec_delay_agnostic_enabled(aec_core)); 68 EXPECT_EQ(1, WebRtcAec_delay_agnostic_enabled(aec_core));
69 69
70 config.Set<DelayAgnostic>(new DelayAgnostic(false)); 70 config.Set<DelayAgnostic>(new DelayAgnostic(false));
71 ap->SetExtraOptions(config); 71 ap->SetExtraOptions(config);
72 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core)); 72 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core));
73 73
74 // Retains setting after initialization. 74 // Retains setting after initialization.
75 EXPECT_EQ(ap->kNoError, ap->Initialize()); 75 EXPECT_EQ(ap->kNoError, ap->Initialize());
76 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core)); 76 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core));
77 } 77 }
78 78
79 } // namespace webrtc 79 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698