webrtc/media/engine/webrtcmediaengine.h - Issue 2685093002: Switching some interfaces to use std::unique_ptr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcmediaengine.h

Issue 2685093002: Switching some interfaces to use std::unique_ptr<>. (Closed)

Patch Set: Rebase onto master Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/engine/webrtcmediaengine.h

diff --git a/webrtc/media/engine/webrtcmediaengine.h b/webrtc/media/engine/webrtcmediaengine.h

index 17e79c6cc10297cd7cd3a79366bd02e2fc4a44e1..b539b5856b7609a81ed1005e3956797ab5a97375 100644

--- a/webrtc/media/engine/webrtcmediaengine.h

+++ b/webrtc/media/engine/webrtcmediaengine.h

@@ -40,6 +40,8 @@ class WebRtcMediaEngineFactory {

WebRtcVideoEncoderFactory* video_encoder_factory,

WebRtcVideoDecoderFactory* video_decoder_factory);

+ // TODO(deadbeef): Change these to return an std::unique_ptr<>, to indicate

+ // that the caller owns the returned object.

static MediaEngineInterface* Create(

webrtc::AudioDeviceModule* adm,

const rtc::scoped_refptr<webrtc::AudioDecoderFactory>&