Switching some interfaces to use std::unique_ptr<>.

webrtc/pc/channelmanager.h

 /*
  *  Copyright 2004 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 21 matching lines @@
 // voice and video channels; by doing so, it can temporarily pause all the
 // channels when a new audio or video device is chosen. The voice and video
 // channels are stored in separate vectors, to easily allow operations on just
 // voice or just video channels.
 // ChannelManager also allows the application to discover what devices it has
 // using device manager.
 class ChannelManager {
  public:
   // For testing purposes. Allows the media engine and data media
   // engine and dev manager to be mocks.  The ChannelManager takes
-  // ownership of these objects.
-  ChannelManager(MediaEngineInterface* me,
-                 DataEngineInterface* dme,
+  // ownership of the objects passed in as unique_ptrs.

[pthatcher1, 2017/02/10 18:21:25]

Isn't that kind of assumed by a std::unique_ptr?  You can probably delete the
whole last sentence there.

[Taylor Brandstetter, 2017/02/10 21:55:48]

Removed.

+  ChannelManager(std::unique_ptr<MediaEngineInterface> me,
+                 std::unique_ptr<DataEngineInterface> dme,
                  rtc::Thread* worker_and_network);
   // Same as above, but gives an easier default DataEngine.
-  ChannelManager(MediaEngineInterface* me,
+  ChannelManager(std::unique_ptr<MediaEngineInterface> me,
                  rtc::Thread* worker,
                  rtc::Thread* network);
   ~ChannelManager();
 
   // Accessors for the worker thread, allowing it to be set after construction,
   // but before Init. set_worker_thread will return false if called after Init.
   rtc::Thread* worker_thread() const { return worker_thread_; }
   bool set_worker_thread(rtc::Thread* thread) {
     if (initialized_) {
       return false;
@@ skipping 92 matching lines @@
   bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes);
 
   // Stops recording AEC dump.
   void StopAecDump();
 
  private:
   typedef std::vector<VoiceChannel*> VoiceChannels;
   typedef std::vector<VideoChannel*> VideoChannels;
   typedef std::vector<RtpDataChannel*> RtpDataChannels;
 
-  void Construct(MediaEngineInterface* me,
-                 DataEngineInterface* dme,
+  void Construct(std::unique_ptr<MediaEngineInterface> me,
+                 std::unique_ptr<DataEngineInterface> dme,
                  rtc::Thread* worker_thread,
                  rtc::Thread* network_thread);
   bool InitMediaEngine_w();
   void DestructorDeletes_w();
   void Terminate_w();
   bool SetCryptoOptions_w(const rtc::CryptoOptions& crypto_options);
   VoiceChannel* CreateVoiceChannel_w(
       webrtc::MediaControllerInterface* media_controller,
       DtlsTransportInternal* rtp_transport,
       DtlsTransportInternal* rtcp_transport,
@@ skipping 39 matching lines @@
 
   bool enable_rtx_;
   rtc::CryptoOptions crypto_options_;
 
   bool capturing_;
 };
 
 }  // namespace cricket
 
 #endif  // WEBRTC_PC_CHANNELMANAGER_H_