webrtc/p2p/base/stunport_unittest.cc - Issue 2685053004: Add the URL attribute to cricket::Candiate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/base/stunport_unittest.cc

Issue 2685053004: Add the URL attribute to cricket::Candiate. (Closed)

Patch Set: CR comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/p2p/base/stunport_unittest.cc

diff --git a/webrtc/p2p/base/stunport_unittest.cc b/webrtc/p2p/base/stunport_unittest.cc

index aa708c1ba196533a88d9b353e1f52671bfa8bada..f8903d3a2fd2f60e1ef396681fc5094059f67478 100644

--- a/webrtc/p2p/base/stunport_unittest.cc

+++ b/webrtc/p2p/base/stunport_unittest.cc

@@ -201,6 +201,8 @@ TEST_F(StunPortTest, TestPrepareAddress) {

EXPECT_TRUE_SIMULATED_WAIT(done(), kTimeoutMs, fake_clock);

ASSERT_EQ(1U, port()->Candidates().size());

EXPECT_TRUE(kLocalAddr.EqualIPs(port()->Candidates()[0].address()));

+ std::string expected_server_url = "stun:127.0.0.1:5000";

+ EXPECT_EQ(port()->Candidates()[0].url(), expected_server_url);

// TODO: Add IPv6 tests here, once either physicalsocketserver supports

// IPv6, or this test is changed to use VirtualSocketServer.