Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: webrtc/p2p/base/stunport_unittest.cc

Issue 2685053004: Add the URL attribute to cricket::Candiate. (Closed)
Patch Set: Add the Server URL to the Candiate. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/stunport_unittest.cc
diff --git a/webrtc/p2p/base/stunport_unittest.cc b/webrtc/p2p/base/stunport_unittest.cc
index aa708c1ba196533a88d9b353e1f52671bfa8bada..88f046c53752505bbfa6a3cc0fbdb6cd90d4528c 100644
--- a/webrtc/p2p/base/stunport_unittest.cc
+++ b/webrtc/p2p/base/stunport_unittest.cc
@@ -201,6 +201,8 @@ TEST_F(StunPortTest, TestPrepareAddress) {
EXPECT_TRUE_SIMULATED_WAIT(done(), kTimeoutMs, fake_clock);
ASSERT_EQ(1U, port()->Candidates().size());
EXPECT_TRUE(kLocalAddr.EqualIPs(port()->Candidates()[0].address()));
+ std::string expected_server_url = "stun:" + kStunAddr1.ToString();
Taylor Brandstetter 2017/02/10 01:58:46 nit: This test relies on SocketAddress::ToString()
Zhi Huang 2017/02/10 06:45:50 Agreed. If we expect that the ToString() might cha
+ EXPECT_EQ(port()->Candidates()[0].url(), expected_server_url);
// TODO: Add IPv6 tests here, once either physicalsocketserver supports
// IPv6, or this test is changed to use VirtualSocketServer.

Powered by Google App Engine
This is Rietveld 408576698