Delete webrtc/base/common.h

webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h

Index: webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h
diff --git a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h
index 1ae24af965e0db4bf0069ff70d915f15748ecb77..c5a16a68b8935ad9378becf041a7d4832107252a 100644
--- a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h
+++ b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h
@@ -250,7 +250,9 @@ class RateCounterFilter : public PacketProcessor {
   Stats<double> packets_per_second_stats_;
   Stats<double> kbps_stats_;
   int64_t start_plotting_time_ms_;
-  int flow_id_;
+#if BWE_TEST_LOGGING_COMPILE_TIME_ENABLE
+  int flow_id_ = 0;
+#endif

[pthatcher1, 2017/02/10 23:44:17]

I don't understand why BWE_TEST_LOGGING_COMPILE_TIME_ENABLE is part of this CL.

[kwiberg-webrtc, 2017/02/11 21:30:06]

I think it is because this variable is only used by code protected by #if
BWE_TEST_LOGGING_COMPILE_TIME_ENABLE; we used to avoid unused variable warnings
by calling RTC_UNUSED(flow_id_), but now we do it like this instead.

nisse@, please correct me if I'm wrong...

[nisse-webrtc, 2017/02/13 12:05:51]

You're right. Without these #ifdefs, I get warnings for unused variables, and
thanks to the use of -Werror, the warnings are fatal.

We could reintroduce RTC_UNUSED or something equivalent (an earlier patchset
used ATTRIBUTE_UNUSED at this location). But if the member variable is needed
only if BWE_... is true at compile time, I think it's good to make that
explicit.

It would perhaps be better to have the #ifdefs take out larger pieces of code,
preferably complete classes or complete files, but that's for some other cl.

   std::string name_;
   // Algorithm name if single flow, Total link utilization if all flows.
   std::string algorithm_name_;