Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: webrtc/base/httpclient.cc

Issue 2684613002: Delete webrtc/base/common.h (Closed)
Patch Set: Fix unusedness warning breaking android build. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/httpclient.cc
diff --git a/webrtc/base/httpclient.cc b/webrtc/base/httpclient.cc
index e65eb9e80c4f05db2f500d91a923f7bee8669d34..be75581da3087af5382d43bff26d5248ccd99ae2 100644
--- a/webrtc/base/httpclient.cc
+++ b/webrtc/base/httpclient.cc
@@ -13,7 +13,6 @@
#include <memory>
#include "webrtc/base/asyncsocket.h"
#include "webrtc/base/checks.h"
-#include "webrtc/base/common.h"
#include "webrtc/base/diskcache.h"
#include "webrtc/base/httpclient.h"
#include "webrtc/base/httpcommon-inl.h"
@@ -23,6 +22,7 @@
#include "webrtc/base/stringencode.h"
#include "webrtc/base/stringutils.h"
#include "webrtc/base/thread.h"
+#include "webrtc/common_types.h"
namespace rtc {
@@ -162,7 +162,7 @@ HttpValidatorStrength
HttpResponseValidatorLevel(const HttpResponseData& response) {
std::string value;
if (response.hasHeader(HH_ETAG, &value)) {
- bool is_weak = (strnicmp(value.c_str(), "W/", 2) == 0);
+ bool is_weak = (STR_NCASE_CMP(value.c_str(), "W/", 2) == 0);
return is_weak ? HVS_WEAK : HVS_STRONG;
}
if (response.hasHeader(HH_LAST_MODIFIED, &value)) {

Powered by Google App Engine
This is Rietveld 408576698