Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc

Issue 2684613002: Delete webrtc/base/common.h (Closed)
Patch Set: Added TODO comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc
index 8b04d00d38e8316208fc8d892b7c963cc6a2069d..f6a61a6e8d79286dc91b102e99426e698935a165 100644
--- a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc
+++ b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc
@@ -14,7 +14,6 @@
#include <sstream>
-#include "webrtc/base/common.h"
#include "webrtc/base/constructormagic.h"
namespace webrtc {
@@ -223,12 +222,11 @@ RateCounterFilter::RateCounterFilter(PacketProcessorListener* listener,
packets_per_second_stats_(),
kbps_stats_(),
start_plotting_time_ms_(0),
+#if BWE_TEST_LOGGING_COMPILE_TIME_ENABLE
flow_id_(flow_id),
+#endif
name_(name),
- algorithm_name_(algorithm_name) {
- // Only used when compiling with BWE test logging enabled.
- RTC_UNUSED(flow_id_);
- }
+ algorithm_name_(algorithm_name) {}
RateCounterFilter::RateCounterFilter(PacketProcessorListener* listener,
const FlowIds& flow_ids,
@@ -238,7 +236,6 @@ RateCounterFilter::RateCounterFilter(PacketProcessorListener* listener,
packets_per_second_stats_(),
kbps_stats_(),
start_plotting_time_ms_(0),
- flow_id_(0),
name_(name),
algorithm_name_(algorithm_name) {
// TODO(terelius): Appending the flow IDs to the algorithm name is a hack to
@@ -278,6 +275,9 @@ Stats<double> RateCounterFilter::GetBitrateStats() const {
}
void RateCounterFilter::Plot(int64_t timestamp_ms) {
+ // TODO(stefan): Reorganize logging configuration to reduce amount
+ // of preprocessor conditionals in the code.
+#if BWE_TEST_LOGGING_COMPILE_TIME_ENABLE
uint32_t plot_kbps = 0;
if (timestamp_ms >= start_plotting_time_ms_) {
plot_kbps = rate_counter_.bits_per_second() / 1000.0;
@@ -291,8 +291,7 @@ void RateCounterFilter::Plot(int64_t timestamp_ms) {
timestamp_ms, plot_kbps, flow_id_,
algorithm_name_);
}
-
- RTC_UNUSED(plot_kbps);
+#endif
}
void RateCounterFilter::RunFor(int64_t /*time_ms*/, Packets* in_out) {

Powered by Google App Engine
This is Rietveld 408576698