Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Side by Side Diff: webrtc/modules/congestion_controller/delay_based_bwe.cc

Issue 2682893003: Log information (at level LS_INFO) about which overuse estimator is used. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 trendline_window_size_(kDefaultTrendlineWindowSize), 221 trendline_window_size_(kDefaultTrendlineWindowSize),
222 trendline_smoothing_coeff_(kDefaultTrendlineSmoothingCoeff), 222 trendline_smoothing_coeff_(kDefaultTrendlineSmoothingCoeff),
223 trendline_threshold_gain_(kDefaultTrendlineThresholdGain), 223 trendline_threshold_gain_(kDefaultTrendlineThresholdGain),
224 probing_interval_estimator_(&rate_control_), 224 probing_interval_estimator_(&rate_control_),
225 median_slope_window_size_(kDefaultMedianSlopeWindowSize), 225 median_slope_window_size_(kDefaultMedianSlopeWindowSize),
226 median_slope_threshold_gain_(kDefaultMedianSlopeThresholdGain) { 226 median_slope_threshold_gain_(kDefaultMedianSlopeThresholdGain) {
227 if (in_trendline_experiment_) { 227 if (in_trendline_experiment_) {
228 ReadTrendlineFilterExperimentParameters(&trendline_window_size_, 228 ReadTrendlineFilterExperimentParameters(&trendline_window_size_,
229 &trendline_smoothing_coeff_, 229 &trendline_smoothing_coeff_,
230 &trendline_threshold_gain_); 230 &trendline_threshold_gain_);
231 LOG(LS_INFO) << "Trendline filter experiment enabled with parameters "
232 << trendline_window_size_ << ',' << trendline_smoothing_coeff_
233 << ',' << trendline_threshold_gain_;
231 } 234 }
232 if (in_median_slope_experiment_) { 235 if (in_median_slope_experiment_) {
233 ReadMedianSlopeFilterExperimentParameters(&median_slope_window_size_, 236 ReadMedianSlopeFilterExperimentParameters(&median_slope_window_size_,
234 &median_slope_threshold_gain_); 237 &median_slope_threshold_gain_);
238 LOG(LS_INFO) << "Median-slope filter experiment enabled with parameters "
239 << median_slope_window_size_ << ','
240 << median_slope_threshold_gain_;
241 }
242 if (!in_trendline_experiment_ && !in_median_slope_experiment_) {
243 LOG(LS_INFO) << "No overuse experiment enabled. Using Kalman filter.";
235 } 244 }
236 245
237 network_thread_.DetachFromThread(); 246 network_thread_.DetachFromThread();
238 } 247 }
239 248
240 DelayBasedBwe::Result DelayBasedBwe::IncomingPacketFeedbackVector( 249 DelayBasedBwe::Result DelayBasedBwe::IncomingPacketFeedbackVector(
241 const std::vector<PacketInfo>& packet_feedback_vector) { 250 const std::vector<PacketInfo>& packet_feedback_vector) {
242 RTC_DCHECK(network_thread_.CalledOnValidThread()); 251 RTC_DCHECK(network_thread_.CalledOnValidThread());
243 if (!uma_recorded_) { 252 if (!uma_recorded_) {
244 RTC_HISTOGRAM_ENUMERATION(kBweTypeHistogram, 253 RTC_HISTOGRAM_ENUMERATION(kBweTypeHistogram,
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 void DelayBasedBwe::SetMinBitrate(int min_bitrate_bps) { 400 void DelayBasedBwe::SetMinBitrate(int min_bitrate_bps) {
392 // Called from both the configuration thread and the network thread. Shouldn't 401 // Called from both the configuration thread and the network thread. Shouldn't
393 // be called from the network thread in the future. 402 // be called from the network thread in the future.
394 rate_control_.SetMinBitrate(min_bitrate_bps); 403 rate_control_.SetMinBitrate(min_bitrate_bps);
395 } 404 }
396 405
397 int64_t DelayBasedBwe::GetProbingIntervalMs() const { 406 int64_t DelayBasedBwe::GetProbingIntervalMs() const {
398 return probing_interval_estimator_.GetIntervalMs(); 407 return probing_interval_estimator_.GetIntervalMs();
399 } 408 }
400 } // namespace webrtc 409 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698