Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1914)

Unified Diff: webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc

Issue 2681033010: Remove usage of VoEAudioProcessing from WVoE/MC. (Closed)
Patch Set: one more Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc
diff --git a/webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc b/webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc
index 360b76bb1ef14fd8a3d99ba25b5f43cd6f2d8677..0fc0d39c73a8f882649b99242ca9f8cf1477c291 100644
--- a/webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc
+++ b/webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc
@@ -22,6 +22,7 @@ class AgcConfigTest : public AfterStreamingFixture {
webrtc::AgcConfig default_agc_config_;
};
+// Duplicated in apm_helpers_unittest.cc.
TEST_F(AgcConfigTest, HasCorrectDefaultConfiguration) {
webrtc::AgcConfig agc_config;
@@ -33,6 +34,7 @@ TEST_F(AgcConfigTest, HasCorrectDefaultConfiguration) {
EXPECT_EQ(default_agc_config_.limiterEnable, agc_config.limiterEnable);
}
+// Not needed anymore - we're not returning errors anymore, just logging.
TEST_F(AgcConfigTest, DealsWithInvalidParameters) {
webrtc::AgcConfig agc_config = default_agc_config_;
agc_config.digitalCompressionGaindB = 91;
@@ -47,6 +49,7 @@ TEST_F(AgcConfigTest, DealsWithInvalidParameters) {
EXPECT_EQ(VE_APM_ERROR, voe_base_->LastError());
}
+// Duplicated in apm_helpers_unittest.cc.
TEST_F(AgcConfigTest, CanGetAndSetAgcStatus) {
webrtc::AgcConfig agc_config;
agc_config.digitalCompressionGaindB = 17;
« no previous file with comments | « webrtc/voice_engine/include/voe_base.h ('k') | webrtc/voice_engine/test/auto_test/extended/ec_metrics_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698