webrtc/modules/audio_processing/aec3/matched_filter_lag_aggregator.cc - Issue 2678423005: Finalization of the first version of EchoCanceller 3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/aec3/matched_filter_lag_aggregator.cc

Issue 2678423005: Finalization of the first version of EchoCanceller 3 (Closed)

Patch Set: Changes in response to reviewer comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_processing/aec3/matched_filter.cc ('K') | « webrtc/modules/audio_processing/aec3/matched_filter.cc ('k') | webrtc/modules/audio_processing/aec3/matched_filter_lag_aggregator_unittest.cc » ('j') | webrtc/modules/audio_processing/aec3/matched_filter_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/aec3/matched_filter_lag_aggregator.cc

diff --git a/webrtc/modules/audio_processing/aec3/matched_filter_lag_aggregator.cc b/webrtc/modules/audio_processing/aec3/matched_filter_lag_aggregator.cc

index d9176efa94fbd76f6d2fbbffa121e7ba2f68e54d..fd5fab160856266ed021a54730b683868d5c4182 100644

--- a/webrtc/modules/audio_processing/aec3/matched_filter_lag_aggregator.cc

+++ b/webrtc/modules/audio_processing/aec3/matched_filter_lag_aggregator.cc

@@ -1,3 +1,4 @@

hlundin-webrtc 2017/02/22 15:24:07 Empty line.

peah-webrtc 2017/02/22 23:51:39 Done.

@@ -59,7 +60,7 @@ rtc::Optional<size_t> MatchedFilterLagAggregator::Aggregate(

candidate_ = lag_estimates[best_lag_estimate_index].lag;

}

- return candidate_counter_ >= 10 ? rtc::Optional<size_t>(candidate_)

+ return candidate_counter_ >= 15 ? rtc::Optional<size_t>(candidate_)

: rtc::Optional<size_t>();

}