Finalization of the first version of EchoCanceller 3

webrtc/modules/audio_processing/aec3/aec3_fft.cc

+/*
+ *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/modules/audio_processing/aec3/aec3_fft.h"
+
+#include <algorithm>
+
+#include "webrtc/base/checks.h"
+
+namespace webrtc {
+
+void Aec3Fft::ZeroPaddedFft(rtc::ArrayView<const float> x, FftData* X) const {

[hlundin-webrtc, 2017/02/21 16:34:02]

Any reason why you are not using an std::array here? I mean, the size of the
input cannot change anyway.

[peah-webrtc, 2017/02/21 23:00:40]

I agree. The reason is that it is called at least once using a vector (inside
echo_remover.cc). Once we refactor out the vector-implementation of the block
implementation, we can, and should, do that change. I'll add a todo for that.

+  RTC_DCHECK(X);
+  RTC_DCHECK_EQ(kFftLengthBy2, x.size());
+  std::array<float, kFftLength> fft;
+  std::fill(fft.begin(), fft.begin() + kFftLengthBy2, 0.f);
+  std::copy(x.begin(), x.end(), fft.begin() + kFftLengthBy2);
+  ooura_fft_.Fft(fft.data());

[hlundin-webrtc, 2017/02/21 16:34:02]

Why not call Fft(&fft, X), like you do in PaddedFft below?

[peah-webrtc, 2017/02/21 23:00:40]

Done.

+  X->CopyFromPackedArray(fft);
+}
+
+void Aec3Fft::PaddedFft(rtc::ArrayView<const float> x,
+                        rtc::ArrayView<float> x_old,
+                        FftData* X) const {
+  RTC_DCHECK(X);
+  RTC_DCHECK_EQ(kFftLengthBy2, x.size());
+  RTC_DCHECK_EQ(kFftLengthBy2, x_old.size());
+  std::array<float, kFftLength> fft;
+  std::copy(x_old.begin(), x_old.end(), fft.begin());
+  std::copy(x.begin(), x.end(), fft.begin() + x.size());

[hlundin-webrtc, 2017/02/21 16:34:02]

I guess this should be x_old.size(). Not that it matters...

[peah-webrtc, 2017/02/21 23:00:40]

Done.

+  std::copy(x.begin(), x.end(), x_old.begin());
+  Fft(&fft, X);
+}
+
+}  // namespace webrtc